This repository was archived by the owner on Apr 3, 2019. It is now read-only.
style(font family): add times instead of fira #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreya99oak
force-pushed
the
issue-#5742
branch
from
752ce73 to
632bed7
Compare
Contributor
Author
|
Is there any particular reason to use times instead of fira? Cause fira was asked to be created by Mozilla |
shane-tomlinson
suggested changes
Mar 27, 2019
shane-tomlinson
left a comment
shane-tomlinson
left a comment
There was a problem hiding this comment.
Thanks @shreya99oak, the problem that @ryanfeeley wants fixed is that Time is unexpectedly used on iOS instead of Fira. We'd expect Fira to be used instead of times.
Contributor
Author
|
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5742
This fixes a part of #5742 which is adding Times as the font family for IOS users.
@shane-tomlinson @lmorchard Pls. review.