This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Re-added support for zyxel.com #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...a different one
Greg-21
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I removed the site-specific rule for zyxel.com, as it is now redundant and does not serve its purpose anymore since they started using the CookieScript CMP (for which support has already been proposed by me in another pull request and is waiting for review). See #467 and #356 for more information.Thanks to abhishekmadan30 and their good knowledge of the subject, support for the cookie banner on zyxel.com is now provided by some other random existing rule.
Fixes #467