Skip to content

Enable RUST_BOOTSTRAP=1 environment #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvark opened this issue May 16, 2019 · 5 comments
Closed

Enable RUST_BOOTSTRAP=1 environment #344

kvark opened this issue May 16, 2019 · 5 comments

Comments

@kvark
Copy link
Contributor

kvark commented May 16, 2019

This would allow having parse.expand.crates in cbindgen.toml without requiring the nightly compiler. Related to #38 . Would make Gecko's life easier.
cc @eqrion @staktrace

@staktrace
Copy link
Contributor

Should be RUSTC_BOOTSTRAP=1 (not RUST_BOOTSTRAP=1). It's basically a hack that allows using nightly -Z flags on stable.

@emilio
Copy link
Collaborator

emilio commented Jun 10, 2019

Why do you want to expand macros in Gecko? We wouldn't be able to do this easily anyhow, I'd think, since cbindgen runs as part of the export phase, and thus cannot depend on other compiled artifacts.

Though maybe since it invokes rustc by itself it'd be fine.

That being said, I think it'd be better to just enable it in Gecko if we were to do this, you can do it easily changing RunCbindgen.py to run with the new environment variable. So I think this is wontfix, in this repo at least.

@emilio emilio closed this as completed Jun 10, 2019
@eliaslevy
Copy link

I would be useful the documentation mentioned that parse.expand requires the use of the nightly compiler.

BTW, what is the reason for this? It seems cargo expand works with stable.

@emilio
Copy link
Collaborator

emilio commented Feb 21, 2020

cbindgen doesn't use cargo expand, it uses rustc --pretty=expanded.

@eliaslevy
Copy link

I am aware. I was wondering why cbindgen requires rustc and the use of a nightly only flag while cargo expand seemingly performs the same function under stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants