Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest filtercascade lib with new hashing algorithm #7412

Closed
eviljeff opened this issue Mar 20, 2020 · 3 comments · Fixed by mozilla/addons-server#13863
Closed
Assignees
Labels
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Mar 20, 2020

blocked on mozilla/filter-cascade#6 (and releasing a new version of filtercascde to pypi)

The salt is now used directly in the bloomfilter so we don't need to prepend it to the key. We should also consider:

@AlexandraMoga
Copy link

@eviljeff is there anything to be tested here?

@eviljeff
Copy link
Member Author

eviljeff commented Apr 1, 2020

nothing special. Just make a change and see there's a kinto record with an attachment created on the normal schedule. (the file should be roughly the same size as before)

@AlexandraMoga
Copy link

I've followed the last couple of records from https://kinto.dev.mozaws.net/v1/buckets/staging_addons_dev_allizom_org/collections/addons-bloomfilters/records and I didn't notice anything out of the ordinary. I don't remember the size of past records, so I can't compare if there are any visible changes here.
In any case, for a collection of 2 new blocks and a block edit, the size was 1857.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants