Launching Firefox without internet connectivity spawns https://rally.mozilla.org/rally-required tab

[gene1wood]

Steps to Reproduce

• Install Firefox 91.0.1 (I'm unsure if the version matters) on Ubuntu 18.04 (I'm unsure if the OS matters)
• Install Rally addon version 1.3.4
• Provision Rally as you normally would, completing enrollment and joining studies
• Close Firefox
• Launch Firefox and see that Rally doesn't spawn a new tab as it understands that you've completed enrollment already
• Close Firefox
• Disconnect your internet connectivity (in my case by disabling wifi)
• Launch Firefox

Expected Results

Firefox should launch, fail to load my old tabs because I have no internet connectivity, but Rally should not do anything.

Actual Results

Firefox launches, restoring tabs and creates a new tab pointing to https://rally.mozilla.org/rally-required

The content of the tab doesn't load as there's no network connectivity.

If you close Firefox and enable internet connectivity, then re-launch Firefox, Firefox will come up, restore tabs and will now have 3 tabs pointing to that URL (I'm not sure why 3 instead of just the original 1).

The tabs say "You haven't agreed to share data from this device yet." and "Complete Enrollment" despite the fact that you've already completed enrollment and already agreed to share data from this device.

It appears that the add-on is misinterpreting the lack of internet connectivity to mean the device hasn't been provisioned.

I can reproduce this scenario at any time by disabling my wifi and launching Firefox.

[rhelmer]

Thanks for the STR! I'll take a look. The enrollment check is from message-passing between the study and core extensions, which shouldn't require networking, so it's likely a bug in the rally SDK (embedded in the study extension and responsible for opening this tab), or in the rally-core extension (which receives messages and holds the enrollment state).

Both the SDK and core extension are in this repo :)

[javaun]

@gene1wood thanks for filing! Do you happen to be using Fx on more than one device (i.e. have multiple machines and are syncing Fx data and add-ons across machines?

[gene1wood]

@javaun I do use Firefox across devices (mobile and work laptop, home desktop etc) but I don't sync add-ons, only Bookmarks, Addresses and Credit Cars

I do run multiple Firefox profiles on my Mozilla work laptop. I run my personal profile in one Firefox instance and my work profile in the other. For one I launch /usr/lib/firefox/firefox --no-remote -P gene --class firefox-gene and for the other I launch /usr/lib/firefox/firefox -P work --class firefox-work. I don't know if this relates or not.

In these two profiles that I run, one of them (my personal profile, not my work profile) has the Rally add-on (and again, I don't sync addons with Firefox Sync)