Skip to content

Commit 93d42e8

Browse files
committed
Revert accidental push of ps debugging API.
This reverts commits 6ad8c96, a3f97d1, 25abe58 I should know better by now than to push without checking for outstanding changes.
1 parent d486ea3 commit 93d42e8

6 files changed

+46
-97
lines changed

boilerplate/cairo-boilerplate-pdf.c

+13-6
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
#if CAIRO_CAN_TEST_PDF_SURFACE
3030

3131
#include <cairo-pdf.h>
32+
#include <cairo-pdf-surface-private.h>
33+
#include <cairo-paginated-surface-private.h>
3234

3335
#if HAVE_SIGNAL_H
3436
#include <signal.h>
@@ -219,18 +221,23 @@ _cairo_boilerplate_pdf_cleanup (void *closure)
219221
}
220222

221223
static void
222-
_cairo_boilerplate_pdf_force_fallbacks (cairo_surface_t *surface,
224+
_cairo_boilerplate_pdf_force_fallbacks (cairo_surface_t *abstract_surface,
223225
double x_pixels_per_inch,
224226
double y_pixels_per_inch)
225227
{
226-
pdf_target_closure_t *ptc =
227-
cairo_surface_get_user_data (surface, &pdf_closure_key);
228+
pdf_target_closure_t *ptc = cairo_surface_get_user_data (abstract_surface,
229+
&pdf_closure_key);
230+
231+
cairo_paginated_surface_t *paginated;
232+
cairo_pdf_surface_t *surface;
228233

229234
if (ptc->target)
230-
surface = ptc->target;
235+
abstract_surface = ptc->target;
231236

232-
cairo_pdf_surface_debug_force_fallbacks (surface);
233-
cairo_surface_set_fallback_resolution (surface,
237+
paginated = (cairo_paginated_surface_t*) abstract_surface;
238+
surface = (cairo_pdf_surface_t*) paginated->target;
239+
surface->force_fallbacks = TRUE;
240+
cairo_surface_set_fallback_resolution (&paginated->base,
234241
x_pixels_per_inch,
235242
y_pixels_per_inch);
236243
}

boilerplate/cairo-boilerplate-ps.c

+33-7
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@
3030

3131
#include <cairo-ps.h>
3232

33+
#include <cairo-ps-surface-private.h>
34+
#include <cairo-paginated-surface-private.h>
35+
3336
#if HAVE_SIGNAL_H
3437
#include <signal.h>
3538
#endif
@@ -52,6 +55,24 @@ typedef struct _ps_target_closure {
5255
cairo_ps_level_t level;
5356
} ps_target_closure_t;
5457

58+
static cairo_status_t
59+
_cairo_boilerplate_ps_surface_set_creation_date (cairo_surface_t *abstract_surface,
60+
time_t date)
61+
{
62+
cairo_paginated_surface_t *paginated = (cairo_paginated_surface_t*) abstract_surface;
63+
cairo_ps_surface_t *surface;
64+
65+
if (cairo_surface_get_type (abstract_surface) != CAIRO_SURFACE_TYPE_PS)
66+
return CAIRO_STATUS_SURFACE_TYPE_MISMATCH;
67+
68+
surface = (cairo_ps_surface_t*) paginated->target;
69+
70+
surface->has_creation_date = TRUE;
71+
surface->creation_date = date;
72+
73+
return CAIRO_STATUS_SUCCESS;
74+
}
75+
5576
static cairo_surface_t *
5677
_cairo_boilerplate_ps_create_surface (const char *name,
5778
cairo_content_t content,
@@ -85,7 +106,7 @@ _cairo_boilerplate_ps_create_surface (const char *name,
85106
goto CLEANUP_FILENAME;
86107

87108
cairo_ps_surface_restrict_to_level (surface, level);
88-
cairo_ps_surface_debug_set_creation_date (surface, 0);
109+
_cairo_boilerplate_ps_surface_set_creation_date (surface, 0);
89110
cairo_surface_set_fallback_resolution (surface, 72., 72.);
90111

91112
if (content == CAIRO_CONTENT_COLOR) {
@@ -262,18 +283,23 @@ _cairo_boilerplate_ps_cleanup (void *closure)
262283
}
263284

264285
static void
265-
_cairo_boilerplate_ps_force_fallbacks (cairo_surface_t *surface,
286+
_cairo_boilerplate_ps_force_fallbacks (cairo_surface_t *abstract_surface,
266287
double x_pixels_per_inch,
267288
double y_pixels_per_inch)
268289
{
269-
ps_target_closure_t *ptc =
270-
cairo_surface_get_user_data (surface, &ps_closure_key);
290+
ps_target_closure_t *ptc = cairo_surface_get_user_data (abstract_surface,
291+
&ps_closure_key);
292+
293+
cairo_paginated_surface_t *paginated;
294+
cairo_ps_surface_t *surface;
271295

272296
if (ptc->target)
273-
surface = ptc->target;
297+
abstract_surface = ptc->target;
274298

275-
cairo_ps_surface_debug_force_fallbacks (surface);
276-
cairo_surface_set_fallback_resolution (surface,
299+
paginated = (cairo_paginated_surface_t*) abstract_surface;
300+
surface = (cairo_ps_surface_t*) paginated->target;
301+
surface->force_fallbacks = TRUE;
302+
cairo_surface_set_fallback_resolution (&paginated->base,
277303
x_pixels_per_inch,
278304
y_pixels_per_inch);
279305
}

src/cairo-pdf-surface.c

-21
Original file line numberDiff line numberDiff line change
@@ -683,27 +683,6 @@ cairo_pdf_surface_set_size (cairo_surface_t *surface,
683683
status = _cairo_surface_set_error (surface, status);
684684
}
685685

686-
/**
687-
* cairo_pdf_surface_debug_force_fallbacks:
688-
* @surface: a PDF #cairo_surface_t
689-
*
690-
* This is purely a debugging interface, intended only to be used in
691-
* conformation testing, to force the surface to contain only rasterised
692-
* graphics and no native PDF drawing.
693-
*
694-
* Since: 1.12.2
695-
**/
696-
void
697-
cairo_pdf_surface_debug_force_fallbacks (cairo_surface_t *abstract_surface)
698-
{
699-
cairo_pdf_surface_t *surface = NULL;
700-
701-
if (! _extract_pdf_surface (abstract_surface, &surface))
702-
return;
703-
704-
surface->force_fallbacks = TRUE;
705-
}
706-
707686
static void
708687
_cairo_pdf_surface_clear (cairo_pdf_surface_t *surface)
709688
{

src/cairo-pdf.h

-5
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ cairo_pdf_surface_set_size (cairo_surface_t *surface,
8585
double width_in_points,
8686
double height_in_points);
8787

88-
/* debug interface */
89-
90-
cairo_public void
91-
cairo_pdf_surface_debug_force_fallbacks (cairo_surface_t *abstract_surface);
92-
9388
CAIRO_END_DECLS
9489

9590
#else /* CAIRO_HAS_PDF_SURFACE */

src/cairo-ps-surface.c

-48
Original file line numberDiff line numberDiff line change
@@ -1358,54 +1358,6 @@ cairo_ps_surface_set_size (cairo_surface_t *surface,
13581358
status = _cairo_surface_set_error (surface, status);
13591359
}
13601360

1361-
/**
1362-
* cairo_ps_surface_debug_set_creation_data:
1363-
* @surface: a PostScript #cairo_surface_t
1364-
* @date: A time_t
1365-
*
1366-
* Changes the embedded creation date of a PostScript surface.
1367-
*
1368-
* This function is only intended to be used by conformance test suites which
1369-
* require complete control over embedded strings.
1370-
*
1371-
* This function can be called at any point before the surface is finished,
1372-
*
1373-
* Since: 1.12.2
1374-
**/
1375-
void
1376-
cairo_ps_surface_debug_set_creation_date (cairo_surface_t *abstract_surface,
1377-
time_t date)
1378-
{
1379-
cairo_ps_surface_t *surface = NULL;
1380-
1381-
if (! _extract_ps_surface (abstract_surface, TRUE, &surface))
1382-
return;
1383-
1384-
surface->has_creation_date = TRUE;
1385-
surface->creation_date = date;
1386-
}
1387-
1388-
/**
1389-
* cairo_ps_surface_debug_force_fallbacks:
1390-
* @surface: a PostScript #cairo_surface_t
1391-
*
1392-
* This is purely a debugging interface, intended only to be used in
1393-
* conformation testing, to force the surface to contain only rasterised
1394-
* graphics and no native PostScript drawing.
1395-
*
1396-
* Since: 1.12.2
1397-
**/
1398-
void
1399-
cairo_ps_surface_debug_force_fallbacks (cairo_surface_t *abstract_surface)
1400-
{
1401-
cairo_ps_surface_t *surface = NULL;
1402-
1403-
if (! _extract_ps_surface (abstract_surface, TRUE, &surface))
1404-
return;
1405-
1406-
surface->force_fallbacks = TRUE;
1407-
}
1408-
14091361
/**
14101362
* cairo_ps_surface_dsc_comment:
14111363
* @surface: a PostScript #cairo_surface_t

src/cairo-ps.h

-10
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
#if CAIRO_HAS_PS_SURFACE
4343

4444
#include <stdio.h>
45-
#include <time.h>
4645

4746
CAIRO_BEGIN_DECLS
4847

@@ -108,15 +107,6 @@ cairo_ps_surface_dsc_begin_setup (cairo_surface_t *surface);
108107
cairo_public void
109108
cairo_ps_surface_dsc_begin_page_setup (cairo_surface_t *surface);
110109

111-
/* debug interface */
112-
113-
cairo_public void
114-
cairo_ps_surface_debug_set_creation_date (cairo_surface_t *abstract_surface,
115-
time_t date);
116-
117-
cairo_public void
118-
cairo_ps_surface_debug_force_fallbacks (cairo_surface_t *abstract_surface);
119-
120110
CAIRO_END_DECLS
121111

122112
#else /* CAIRO_HAS_PS_SURFACE */

0 commit comments

Comments
 (0)