feat: separate background by preview/rendering #1027
Conversation
There's already a export class ProjectMetadata /* ... */ {
// ...
public override set(
value: Partial<ValueOf<ReturnType<typeof createProjectMetadata>>>,
) {
if (value.shared && 'background' in value.shared) {
const background = value.shared.background as Color | null;
delete value.shared.background;
if (value.preview) {
value.preview.background = background;
}
if (value.rendering) {
value.rendering.background = background;
}
}
super.set(value);
}
}We also don't support forward compatibility since that's practically impossible. There are lots of new features being added in each version so trying to open a project with an older editor will almost always fail. |
| @@ -17,7 +17,7 @@ export function StageView({ | |||
| ...rest | |||
| }: StageViewProps) { | |||
| const localRef = useRef<HTMLDivElement>(); | |||
| const {background} = useSharedSettings(); | |||
| const {background} = usePreviewSettings(); | |||
There was a problem hiding this comment.
StageView is used to display the animation in all three places:
PresentationMode- uses rendering settingsRenderingViewport- uses rendering settingsPreviewStage- uses preview settings
So the background should probably be passed here as a prop depending on the context in which the stage is used.
Closes: #1018
Some issues:
To address backwards compatibility issues, one approach is to introduce some sort of a "deprecated"/"hidden" flag for old fields to hide them in the preview, and then set the preview & render backgrounds accordingly on initial project load. Happy to introduce such a thing in a separate PR before merging this.
To address forwards compatibility issues, we could sync the deprecated background field above to one of the preview or render settings (not sure which is better). Although I'm not sure how concerned we are with forwards compatibility.
Let me know your thoughts @aarthificial