Skip to content

Commit cdc94ba

Browse files
committed
Rename eval-in-other-ns to follow convention
1 parent 21cf73e commit cdc94ba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.org

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@
4040
Doing this should populate the view's list with the now evaluated treemap, ready to inspect!
4141

4242
** Configuration
43-
reveal-remote-mode exposes two meaningful variables: the interrelated ~reveal-remote-mode-eval-in-other-ns~ and ~reveal-remote-other-ns~. By default Reveal evaluates the received form (and thus all sub forms) in the ~vlaaad.reveal.ext~ namespace, causing any unknown symbols to result in compile errors (as per regular Clojure semantics). We can configure this behavior using the ~:ns~ key, which reveal-remote-mode defaults to whatever is in ~*ns*~. Setting ~reveal-remote-mode-eval-in-other-ns~ allows you to toggle this behaviour (default ~t~), ~reveal-remote-other-ns~ allows you to specify the value of ~:ns~.
43+
reveal-remote-mode exposes two meaningful variables: the interrelated ~reveal-remote-eval-in-other-ns~ and ~reveal-remote-other-ns~. By default Reveal evaluates the received form (and thus all sub forms) in the ~vlaaad.reveal.ext~ namespace, causing any unknown symbols to result in compile errors (as per regular Clojure semantics). We can configure this behavior using the ~:ns~ key, which reveal-remote-mode defaults to whatever is in ~*ns*~. Setting ~reveal-remote-eval-in-other-ns~ allows you to toggle this behaviour (default ~t~), ~reveal-remote-other-ns~ allows you to specify the value of ~:ns~.
4444

4545
In addition to these, there is also a list called ~reveal-remote-views~ that enumerates the possible Reveal views. This is the place where you would add custom views.
4646

4747
| Variables | Values |
4848
|-------------------------------------+------------------------------------------------------|
49-
| ~reveal-remote-mode-eval-in-other-ns~ | ~t~ (default), ~nil~ |
49+
| ~reveal-remote-eval-in-other-ns~ | ~t~ (default), ~nil~ |
5050
| ~reveal-remote-other-ns~ | ~*ns*~ (default), any valid Clojure namespace (string) |
5151
| ~reveal-remote-env~ | any valid Clojure form (string), nil (default) |
5252
| ~reveal-remote-views~ | Alist of Reveal views |

reveal-remote-mode.el

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
:group 'reveal-remote
5454
:type 'string)
5555

56-
(defcustom reveal-remote-mode-eval-in-other-ns t
56+
(defcustom reveal-remote-eval-in-other-ns t
5757
"If non-nil (default), evaluates forms in the current buffer's namespace.
5858
5959
By default, Reveal evaluates any forms it encounters in vlaaad.reveal.ext,
@@ -62,7 +62,7 @@ which means that any unknown symbols will result in compile errors."
6262
:type 'boolean)
6363

6464
(defcustom reveal-remote-other-ns "*ns*" ; not sure how robust it is to rely on *ns*
65-
"The namespace used when `reveal-remote-mode-eval-in-other-ns' is non-nil."
65+
"The namespace used when `reveal-remote-eval-in-other-ns' is non-nil."
6666
:group 'reveal-remote
6767
:type 'string)
6868

@@ -99,7 +99,7 @@ which means that any unknown symbols will result in compile errors."
9999
(format "{:vlaaad.reveal/command '((requiring-resolve 'vlaaad.reveal.ext/%s) %s) %s %s}"
100100
command
101101
(or arg "")
102-
(or (when reveal-remote-mode-eval-in-other-ns
102+
(or (when reveal-remote-eval-in-other-ns
103103
(format ":ns %s" reveal-remote-other-ns)) "")
104104
(or (when reveal-remote-env
105105
(format ":env %s" reveal-remote-env)) "")))

0 commit comments

Comments
 (0)