Skip to content

Commit 68d2b7f

Browse files
authored
Fix/a corner case of remote workspace detection (#1183)
1 parent 8a022e9 commit 68d2b7f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

testplan/common/remote/remote_resource.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,10 @@ def _create_remote_dirs(self) -> None:
276276
label="remove remote plan runpath",
277277
)
278278

279+
# NOTE: corner case: runpath under workspace
280+
# NOTE: should check existence before any mkdir call
281+
exist_on_remote = self._check_workspace()
282+
279283
self._execute_cmd_remote(
280284
cmd=mkdir_cmd(self._remote_plan_runpath),
281285
label="create remote plan runpath",
@@ -290,7 +294,6 @@ def _create_remote_dirs(self) -> None:
290294
# TODO: testplan_lib will resolved to site-packages under venv,
291295
# TODO: while rpyc_classic.py under bin isn't included
292296

293-
exist_on_remote = self._check_workspace()
294297
self._prepare_workspace(exist_on_remote)
295298

296299
# NOTE: if workspace under testplan_lib (testplan installed in

0 commit comments

Comments
 (0)