From b5c36b30e462519a9d63875a9f065b05c928af89 Mon Sep 17 00:00:00 2001 From: Miles Johnson Date: Mon, 5 Jun 2023 11:17:10 -0700 Subject: [PATCH] fix: Remove --title arg from node. --- .../run_node_test__passes_args_to_the_node_bin.snap | 5 ++--- crates/node/platform/src/actions/run_target.rs | 4 ++-- packages/cli/CHANGELOG.md | 2 ++ 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap b/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap index 9a5853455dc..f5eeea786b0 100644 --- a/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap +++ b/crates/cli/tests/snapshots/run_node_test__passes_args_to_the_node_bin.snap @@ -1,11 +1,10 @@ --- source: crates/cli/tests/run_node_test.rs -assertion_line: 194 -expression: "get_path_safe_output(&assert, fixture.path())" +expression: assert.output() --- ▪▪▪▪ npm install ▪▪▪▪ node:binExecArgs -[ '--title', 'node:binExecArgs', '--preserve-symlinks' ] +[ '--preserve-symlinks' ] ▪▪▪▪ node:binExecArgs (100ms) Tasks: 1 completed diff --git a/crates/node/platform/src/actions/run_target.rs b/crates/node/platform/src/actions/run_target.rs index cb9fbe75744..75805a4e8ba 100644 --- a/crates/node/platform/src/actions/run_target.rs +++ b/crates/node/platform/src/actions/run_target.rs @@ -27,8 +27,8 @@ fn create_node_options( ) -> Result, MoonError> { let mut options = string_vec![ // "--inspect", // Enable node inspector - "--title", - &task.target.id, + // "--title", + // &task.target.id, ]; options.extend(node_config.bin_exec_args.to_owned()); diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md index b2102588e98..26b1df9d6be 100644 --- a/packages/cli/CHANGELOG.md +++ b/packages/cli/CHANGELOG.md @@ -4,6 +4,8 @@ #### 🐞 Fixes +- Node.js + - Fixed an issue where some workers/packages would fail while inheriting parent args. - Rust - Fixed an issue where `cargo generate-lockfile` would run in the wrong directory.