fix: Move version check back into a thread. (#668)

* Place back in a thread.

* Update changelog.

Author: milesj

crates/cli/src/lib.rs

@@ -84,6 +84,8 @@ pub async fn run_cli() {
     setup_logging(&args.log, args.log_file);
     setup_caching(&args.cache);
 
+    let version_check = tokio::spawn(check_version(env!("CARGO_PKG_VERSION")));
+
     // Match and run subcommand
     let result = match args.command {
         Commands::Bin { tool } => bin(tool).await,
@@ -287,14 +289,14 @@ pub async fn run_cli() {
 
     // Defer checking for a new version as it requires the workspace root
     // to exist. Otherwise, the `init` command would panic while checking!
-    match check_version(env!("CARGO_PKG_VERSION")).await {
-        Ok((newer_version, true)) => {
+    match version_check.await {
+        Ok(Ok((newer_version, true))) => {
             println!(
                 "There's a new version of moon! {newer_version}\n\
                 Run `moon upgrade` or install from https://moonrepo.dev/docs/install",
             );
         }
-        Err(error) => {
+        Ok(Err(error)) => {
             debug!(target: "moon:cli", "Failed to check for current version: {}", error);
         }
         _ => {}

crates/core/launchpad/src/lib.rs

@@ -12,7 +12,7 @@ use std::time::{Duration, SystemTime};
 use uuid::Uuid;
 
 const CURRENT_VERSION_URL: &str = "https://launch.moonrepo.app/versions/cli/current";
-const ALERT_PAUSE_DURATION: Duration = Duration::from_secs(28800); // 8 hours
+const ALERT_PAUSE_DURATION: Duration = Duration::from_secs(43200); // 12 hours
 
 #[derive(Debug, Deserialize, Serialize)]
 pub struct CurrentVersion {
@@ -63,7 +63,7 @@ pub async fn check_version(
     let check_state_path = moon_dir.join("cache/states/versionCheck.json");
     let now = SystemTime::now();
 
-    // Only check once every 8 hours
+    // Only check once every 12 hours
     if let Ok(file) = fs::read(&check_state_path) {
         let check_state: Result<CheckState, _> = serde_json::from_str(&file);
 

packages/cli/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - Fixed an issue where workspace relative `outputs` were not being included in the hashed tarball.
 
+#### ⚙️ Internal
+
+- Reduced new version check to once every 12 hours.
+
 ## 0.25.2
 
 #### 🐞 Fixes