Make shim-array.js less breaking world around#173
Make shim-array.js less breaking world around#173a-x- wants to merge 1 commit intomontagejs:masterfrom
Conversation
|
lgtm |
|
Can you rebase on master @a-x- ? |
|
done |
|
Some test still break I will check why. |
|
Need refactor to use internals if not extended. |
|
could you add an example? As I understand someone may keep native, say, Am I correct? |
|
@a-x- Sorry I really like to have that merge for fixing #196 but your changes break the tests.
No. What I propose is make sure collections internally use his Array functions if there have a difference with Native Array or use private functions if needed. |
|
@a-x- I cannot merge if test fails. to run test:
|
closes #169 collections breaks Array.from with Iterables