Skip to content

Commit f07b8c3

Browse files
authored
Fixed vehicle api mapping for POST request (#877)
1 parent 04dad01 commit f07b8c3

File tree

4 files changed

+27
-17
lines changed

4 files changed

+27
-17
lines changed

packages/network/src/api/inspection/mappers.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -590,15 +590,15 @@ export function mapApiInspectionPost(options: CreateInspectionOptions): ApiInspe
590590
mileage:
591591
options.vehicle.mileageUnit && options.vehicle.mileageValue
592592
? {
593-
mileage_value: options.vehicle.mileageValue,
594-
mileage_unit: options.vehicle.mileageUnit,
593+
value: options.vehicle.mileageValue,
594+
unit: options.vehicle.mileageUnit,
595595
}
596596
: undefined,
597597
market_value:
598598
options.vehicle.marketValueUnit && options.vehicle.marketValue
599599
? {
600-
market_value_value: options.vehicle.marketValue,
601-
market_value_unit: options.vehicle.marketValueUnit,
600+
value: options.vehicle.marketValue,
601+
unit: options.vehicle.marketValueUnit,
602602
}
603603
: undefined,
604604
vin: options.vehicle.vin,

packages/network/src/api/models/vehicle.ts

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ export type ApiMileageUnit = 'km' | 'miles';
66

77
export type ApiMarketValueUnit = 'USD' | 'EUR';
88

9-
export interface ApiMileage {
9+
export interface ApiMileageGet {
1010
mileage_value: number;
1111
mileage_unit: ApiMileageUnit;
1212
}
1313

14-
export interface ApiMarketValue {
14+
export interface ApiMarketValueGet {
1515
market_value_value: number;
1616
market_value_unit: ApiMarketValueUnit;
1717
}
@@ -28,8 +28,8 @@ export interface ApiVehicleComponent {
2828
exterior_cleanliness?: string;
2929
id: string;
3030
interior_cleanliness?: string;
31-
mileage?: ApiMileage;
32-
market_value?: ApiMarketValue;
31+
mileage?: ApiMileageGet;
32+
market_value?: ApiMarketValueGet;
3333
model?: string;
3434
serie?: string;
3535
owner_info?: ApiOwnerInfo;
@@ -40,13 +40,23 @@ export interface ApiVehicleComponent {
4040
vin?: string;
4141
}
4242

43+
export interface ApiMileagePost {
44+
value: number;
45+
unit: ApiMileageUnit;
46+
}
47+
48+
export interface ApiMarketValuePost {
49+
value: number;
50+
unit: ApiMarketValueUnit;
51+
}
52+
4353
export interface ApiVehiclePostPatch {
4454
brand?: string;
4555
model?: string;
4656
plate?: string;
4757
vehicle_type?: string;
48-
mileage?: ApiMileage;
49-
market_value?: ApiMarketValue;
58+
mileage?: ApiMileagePost;
59+
market_value?: ApiMarketValuePost;
5060
serie?: string;
5161
vehicle_style?: string;
5262
vehicle_age?: string;

packages/network/src/api/vehicle/mappers.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ export function mapApiVehiclePatch(options: Partial<Vehicle>): ApiVehiclePostPat
1010
mileage:
1111
options.mileageValue && options.mileageUnit
1212
? {
13-
mileage_value: options.mileageValue,
14-
mileage_unit: options.mileageUnit,
13+
value: options.mileageValue,
14+
unit: options.mileageUnit,
1515
}
1616
: undefined,
1717
market_value:
1818
options.marketValue && options.marketValueUnit
19-
? { market_value_value: options.marketValue, market_value_unit: options.marketValueUnit }
19+
? { value: options.marketValue, unit: options.marketValueUnit }
2020
: undefined,
2121
vin: options.vin,
2222
color: options.color,

packages/network/test/api/inspection/data/apiInspectionPost.data.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
"plate": "plate",
2929
"vehicle_type": "hatchback",
3030
"mileage": {
31-
"mileage_unit": "mileageUnit",
32-
"mileage_value": 34
31+
"unit": "mileageUnit",
32+
"value": 34
3333
},
3434
"market_value": {
35-
"market_value_unit": "marketValueUnit",
36-
"market_value_value": 45
35+
"unit": "marketValueUnit",
36+
"value": 45
3737
},
3838
"vin": "vin",
3939
"color": "color",

0 commit comments

Comments
 (0)