MONGOID-5667 [Monkey Patch Removal] Remove String/Integer#unconvertable_to_bson? (#5704)

* Remove String#unconvertable_to_bson? and Integer#unconvertable_to_bson?

* Remove one more usage

* MONGOID-5667 deprecate instead of remove

---------

Co-authored-by: Jamis Buck <[email protected]>

Author: johnnyshields

lib/mongoid/extensions/integer.rb

@@ -33,9 +33,11 @@ def numeric?
       #   object.unconvertable_to_bson?
       #
       # @return [ true ] If the object is unconvertable.
+      # @deprecated
       def unconvertable_to_bson?
         true
       end
+      Mongoid.deprecate(self, :unconvertable_to_bson?)
 
       module ClassMethods
 

lib/mongoid/extensions/string.rb

@@ -8,7 +8,9 @@ module Extensions
     module String
 
       # @attribute [rw] unconvertable_to_bson If the document is unconvertable.
+      # @deprecated
       attr_accessor :unconvertable_to_bson
+      Mongoid.deprecate(self, :unconvertable_to_bson, :unconvertable_to_bson=)
 
       # Evolve the string into an object id if possible.
       #
@@ -126,15 +128,18 @@ def before_type_cast?
         ends_with?("_before_type_cast")
       end
 
+
       # Is the object not to be converted to bson on criteria creation?
       #
       # @example Is the object unconvertable?
       #   object.unconvertable_to_bson?
       #
       # @return [ true | false ] If the object is unconvertable.
+      # @deprecated
       def unconvertable_to_bson?
         @unconvertable_to_bson ||= false
       end
+      Mongoid.deprecate(self, :unconvertable_to_bson?)
 
       private