CLOUDP-87553: Add infrastructure labels to clusters created via quickstart (#667)

Author: gssbzn

internal/cli/atlas/clusters/clusters.go

@@ -21,6 +21,7 @@ import (
 	"github.com/mongodb/mongocli/internal/cli/atlas/onlinearchive"
 	"github.com/mongodb/mongocli/internal/cli/atlas/search"
 	"github.com/spf13/cobra"
+	atlas "go.mongodb.org/atlas/mongodbatlas"
 )
 
 func Builder() *cobra.Command {
@@ -49,3 +50,20 @@ func Builder() *cobra.Command {
 
 	return cmd
 }
+
+func AddLabel(out *atlas.Cluster, l atlas.Label) {
+	if LabelExists(out.Labels, l) {
+		return
+	}
+
+	out.Labels = append(out.Labels, l)
+}
+
+func LabelExists(labels []atlas.Label, l atlas.Label) bool {
+	for _, v := range labels {
+		if v.Key == l.Key && v.Value == l.Value {
+			return true
+		}
+	}
+	return false
+}

internal/cli/atlas/clusters/clusters_test.go

@@ -20,6 +20,7 @@ import (
 	"testing"
 
 	"github.com/mongodb/mongocli/internal/test"
+	"go.mongodb.org/atlas/mongodbatlas"
 )
 
 func TestBuilder(t *testing.T) {
@@ -30,3 +31,97 @@ func TestBuilder(t *testing.T) {
 		[]string{},
 	)
 }
+
+func TestAddLabel(t *testing.T) {
+	type args struct {
+		out   *mongodbatlas.Cluster
+		label mongodbatlas.Label
+	}
+	tests := []struct {
+		name     string
+		args     args
+		wantsAdd bool
+	}{
+		{
+			name: "adds",
+			args: args{
+				out: &mongodbatlas.Cluster{
+					Labels: []mongodbatlas.Label{},
+				},
+				label: mongodbatlas.Label{Key: "test", Value: "test"},
+			},
+			wantsAdd: true,
+		},
+		{
+			name: "doesn't adds",
+			args: args{
+				out: &mongodbatlas.Cluster{
+					Labels: []mongodbatlas.Label{{Key: "test", Value: "test"}},
+				},
+				label: mongodbatlas.Label{Key: "test", Value: "test"},
+			},
+			wantsAdd: true,
+		},
+	}
+	for _, tt := range tests {
+		name := tt.name
+		args := tt.args
+		wantsAdd := tt.wantsAdd
+		t.Run(name, func(t *testing.T) {
+			AddLabel(args.out, args.label)
+			if exists := LabelExists(args.out.Labels, args.label); exists != wantsAdd {
+				t.Errorf("wants to add %v, got %v\n", wantsAdd, exists)
+			}
+		})
+	}
+}
+
+func TestLabelExists(t *testing.T) {
+	type args struct {
+		labels []mongodbatlas.Label
+		l      mongodbatlas.Label
+	}
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			name: "label doesn't exist",
+			args: args{
+				labels: []mongodbatlas.Label{},
+				l: mongodbatlas.Label{
+					Key:   "test",
+					Value: "test",
+				},
+			},
+			want: false,
+		},
+		{
+			name: "label exist",
+			args: args{
+				labels: []mongodbatlas.Label{
+					{
+						Key:   "test",
+						Value: "test",
+					},
+				},
+				l: mongodbatlas.Label{
+					Key:   "test",
+					Value: "test",
+				},
+			},
+			want: true,
+		},
+	}
+	for _, tt := range tests {
+		name := tt.name
+		args := tt.args
+		want := tt.want
+		t.Run(name, func(t *testing.T) {
+			if got := LabelExists(args.labels, args.l); got != want {
+				t.Errorf("LabelExists() = %v, want %v", got, want)
+			}
+		})
+	}
+}

internal/cli/atlas/clusters/create.go

@@ -104,29 +104,15 @@ func (opts *CreateOpts) newCluster() (*atlas.Cluster, error) {
 		cluster.Name = opts.name
 	}
 
-	updateLabels(cluster)
+	AddLabel(cluster, atlas.Label{
+		Key:   labelKey,
+		Value: labelValue,
+	})
 
 	cluster.GroupID = opts.ConfigProjectID()
 	return cluster, nil
 }
 
-func updateLabels(out *atlas.Cluster) {
-	found := false
-	for _, v := range out.Labels {
-		if v.Key == labelKey && v.Value == labelValue {
-			found = true
-			break
-		}
-	}
-
-	if !found {
-		out.Labels = append(out.Labels, atlas.Label{
-			Key:   labelKey,
-			Value: labelValue,
-		})
-	}
-}
-
 func (opts *CreateOpts) applyOpts(out *atlas.Cluster) {
 	replicationSpec := opts.newReplicationSpec()
 	if opts.backup {

internal/cli/atlas/clusters/update.go

@@ -101,8 +101,10 @@ func (opts *UpdateOpts) patchOpts(out *atlas.Cluster) {
 	if opts.tier != "" {
 		out.ProviderSettings.InstanceSizeName = opts.tier
 	}
-
-	updateLabels(out)
+	AddLabel(out, atlas.Label{
+		Key:   labelKey,
+		Value: labelValue,
+	})
 }
 
 // mongocli atlas cluster(s) update [name] --projectId projectId [--tier M#] [--diskSizeGB N] [--mdbVersion]

internal/cli/atlas/quickstart/quick_start.go

@@ -260,15 +260,23 @@ func (opts *Opts) newProjectIPAccessList() []*atlas.ProjectIPAccessList {
 
 func (opts *Opts) newCluster() *atlas.Cluster {
 	diskSizeGB := atlas.DefaultDiskSizeGB[strings.ToUpper(tenant)][tier]
-	return &atlas.Cluster{
+	cluster := &atlas.Cluster{
 		GroupID:             opts.ConfigProjectID(),
 		ClusterType:         replicaSet,
 		ReplicationSpecs:    []atlas.ReplicationSpec{opts.newReplicationSpec()},
 		ProviderSettings:    opts.newProviderSettings(),
 		MongoDBMajorVersion: mdbVersion,
 		DiskSizeGB:          &diskSizeGB,
 		Name:                opts.ClusterName,
+		Labels: []atlas.Label{
+			{
+				Key:   "Infrastructure Tool",
+				Value: "MongoDB CLI Quickstart",
+			},
+		},
 	}
+
+	return cluster
 }
 
 func (opts *Opts) newReplicationSpec() atlas.ReplicationSpec {