CLOUDP-124943: Enable/disable telemetry in mongosh when changed in atlas cli (#1306)

Author: fmenezes

internal/cli/config/set.go

@@ -21,6 +21,7 @@ import (
 	"github.com/mongodb/mongodb-atlas-cli/internal/cli"
 	"github.com/mongodb/mongodb-atlas-cli/internal/cli/require"
 	"github.com/mongodb/mongodb-atlas-cli/internal/config"
+	"github.com/mongodb/mongodb-atlas-cli/internal/mongosh"
 	"github.com/mongodb/mongodb-atlas-cli/internal/search"
 	"github.com/mongodb/mongodb-atlas-cli/internal/validate"
 	"github.com/spf13/cobra"
@@ -53,6 +54,14 @@ func (opts *SetOpts) Run() error {
 	} else {
 		opts.store.Set(opts.prop, value)
 	}
+
+	if opts.prop == config.TelemetryEnabledProperty && mongosh.Detect() {
+		err := mongosh.SetTelemetry(value.(bool))
+		if err != nil {
+			return fmt.Errorf("error setting telemetry on mongosh: %w", err)
+		}
+	}
+
 	if err := opts.store.Save(); err != nil {
 		return err
 	}

internal/config/profile.go

@@ -66,7 +66,7 @@ const (
 	configPerm                   = 0600
 	defaultPermissions           = 0700
 	skipUpdateCheck              = "skip_update_check"
-	telemetryEnabled             = "telemetry_enabled"
+	TelemetryEnabledProperty     = "telemetry_enabled"
 	MongoCLI                     = "mongocli"
 	AtlasCLI                     = "atlascli"
 )
@@ -123,7 +123,7 @@ func Properties() []string {
 		opsManagerSkipVerify,
 		mongoShellPath,
 		skipUpdateCheck,
-		telemetryEnabled,
+		TelemetryEnabledProperty,
 		AccessTokenField,
 		RefreshTokenField,
 	}
@@ -132,14 +132,14 @@ func Properties() []string {
 func BooleanProperties() []string {
 	return []string{
 		skipUpdateCheck,
-		telemetryEnabled,
+		TelemetryEnabledProperty,
 	}
 }
 
 func GlobalProperties() []string {
 	return []string{
 		skipUpdateCheck,
-		telemetryEnabled,
+		TelemetryEnabledProperty,
 		mongoShellPath,
 	}
 }
@@ -419,13 +419,13 @@ func (*Profile) SetSkipUpdateCheck(v bool) {
 // IsTelemetryEnabledSet return true if telemetry_enabled has been set.
 func IsTelemetryEnabledSet() bool { return Default().IsTelemetryEnabledSet() }
 func (*Profile) IsTelemetryEnabledSet() bool {
-	return viper.IsSet(telemetryEnabled)
+	return viper.IsSet(TelemetryEnabledProperty)
 }
 
 // TelemetryEnabled get the configured telemetry enabled value.
 func TelemetryEnabled() bool { return Default().TelemetryEnabled() }
 func (p *Profile) TelemetryEnabled() bool {
-	return isTelemetryFeatureAllowed() && p.GetBoolWithDefault(telemetryEnabled, true)
+	return isTelemetryFeatureAllowed() && p.GetBoolWithDefault(TelemetryEnabledProperty, true)
 }
 
 // SetTelemetryEnabled sets the telemetry enabled value.
@@ -435,7 +435,7 @@ func (*Profile) SetTelemetryEnabled(v bool) {
 	if !isTelemetryFeatureAllowed() {
 		return
 	}
-	SetGlobal(telemetryEnabled, v)
+	SetGlobal(TelemetryEnabledProperty, v)
 }
 
 func boolEnv(key string) bool {

internal/mongosh/mongosh.go

@@ -32,8 +32,20 @@ func binPath() string {
 	return ""
 }
 
-func Run(username, password, mongoURI string) error {
-	args := []string{mongoshBin, "-u", username, "-p", password, mongoURI}
+func execCommand(args ...string) error {
+	a := append([]string{mongoshBin}, args...)
 	env := os.Environ()
-	return syscall.Exec(binPath(), args, env) //nolint:gosec // false positive, this path won't be tampered
+	return syscall.Exec(binPath(), a, env) //nolint:gosec // false positive, this path won't be tampered
+}
+
+func SetTelemetry(enable bool) error {
+	cmd := "disableTelemetry()"
+	if enable {
+		cmd = "enableTelemetry()"
+	}
+	return execCommand("--nodb", "--eval", cmd)
+}
+
+func Run(username, password, mongoURI string) error {
+	return execCommand("-u", username, "-p", password, mongoURI)
 }

internal/telemetry/command.go

@@ -44,7 +44,7 @@ func StartTrackingCommand(cmd *cobra.Command, args []string) {
 }
 
 func FinishTrackingCommand(opt TrackOptions) {
-	if !config.TelemetryEnabled() {
+	if !config.TelemetryEnabled() || currentTracker == nil {
 		return
 	}