fix: complete set param feature (#600)

Author: gssbzn

internal/convert/process_config.go

@@ -241,10 +241,7 @@ func newMongosProcessConfig(p *opsmngr.Process) *ProcessConfig {
 func newMongosProcess(p *ProcessConfig, cluster string) *opsmngr.Process {
 	process := p.process()
 	process.Cluster = cluster
-	process.Args26 = opsmngr.Args26{
-		NET:       p.net(),
-		SystemLog: p.systemLog(),
-	}
+	process.Args26 = p.args26()
 	if p.Security != nil {
 		process.Args26.Security = p.Security
 	}
@@ -255,18 +252,27 @@ func newMongosProcess(p *ProcessConfig, cluster string) *opsmngr.Process {
 	return process
 }
 
+func (p *ProcessConfig) args26() opsmngr.Args26 {
+	return opsmngr.Args26{
+		NET:          p.net(),
+		SystemLog:    p.systemLog(),
+		SetParameter: p.SetParameter,
+	}
+}
+
+func (p *ProcessConfig) args26RS(rsSetName string) opsmngr.Args26 {
+	args26 := p.args26()
+	args26.Replication = &opsmngr.Replication{ReplSetName: rsSetName}
+	args26.Storage = p.storage()
+	return args26
+}
+
 // newReplicaSetProcess generates a mongo process for a replica set mongod
 func newReplicaSetProcess(p *ProcessConfig, replSetName string) *opsmngr.Process {
 	process := p.process()
 
-	process.Args26 = opsmngr.Args26{
-		NET: p.net(),
-		Replication: &opsmngr.Replication{
-			ReplSetName: replSetName,
-		},
-		Storage:   p.storage(),
-		SystemLog: p.systemLog(),
-	}
+	process.Args26 = p.args26RS(replSetName)
+
 	if p.Security != nil {
 		process.Args26.Security = p.Security
 	}
@@ -281,15 +287,8 @@ func newReplicaSetProcess(p *ProcessConfig, replSetName string) *opsmngr.Process
 func newConfigRSProcess(p *ProcessConfig, rsSetName string) *opsmngr.Process {
 	process := p.process()
 
-	process.Args26 = opsmngr.Args26{
-		NET: p.net(),
-		Replication: &opsmngr.Replication{
-			ReplSetName: rsSetName,
-		},
-		Storage:   p.storage(),
-		Sharding:  &opsmngr.Sharding{ClusterRole: "configsvr"},
-		SystemLog: p.systemLog(),
-	}
+	process.Args26 = p.args26RS(rsSetName)
+	process.Args26.Sharding = &opsmngr.Sharding{ClusterRole: "configsvr"}
 	if p.Security != nil {
 		process.Args26.Security = p.Security
 	}

internal/convert/process_config_test.go

@@ -55,6 +55,9 @@ func Test_newReplicaSetProcessConfig(t *testing.T) {
 				Destination: "file",
 				Path:        "/data/log/mongodb.log",
 			},
+			SetParameter: &map[string]interface{}{
+				"param": "param",
+			},
 		},
 		AuthSchemaVersion:           5,
 		Disabled:                    false,
@@ -103,6 +106,9 @@ func Test_newReplicaSetProcessConfig(t *testing.T) {
 		Disabled:            false,
 		Hidden:              pointy.Bool(false),
 		TLS:                 &TLS{Mode: "disabled"},
+		SetParameter: &map[string]interface{}{
+			"param": "param",
+		},
 		WiredTiger: &map[string]interface{}{
 			"collectionConfig": map[string]interface{}{},
 			"engineConfig": map[string]interface{}{
@@ -147,6 +153,9 @@ func Test_newConfigRSProcess(t *testing.T) {
 			},
 			"indexConfig": map[string]interface{}{},
 		},
+		SetParameter: &map[string]interface{}{
+			"param": "param",
+		},
 	}
 
 	want := &opsmngr.Process{
@@ -180,6 +189,9 @@ func Test_newConfigRSProcess(t *testing.T) {
 				Path:        "/data/log/mongodb.log",
 			},
 			Sharding: &opsmngr.Sharding{ClusterRole: "configsvr"},
+			SetParameter: &map[string]interface{}{
+				"param": "param",
+			},
 		},
 		AuthSchemaVersion:           5,
 		Disabled:                    false,
@@ -229,6 +241,9 @@ func Test_newReplicaSetProcess(t *testing.T) {
 			},
 			"indexConfig": map[string]interface{}{},
 		},
+		SetParameter: &map[string]interface{}{
+			"param": "param",
+		},
 	}
 
 	want := &opsmngr.Process{
@@ -261,6 +276,9 @@ func Test_newReplicaSetProcess(t *testing.T) {
 				Destination: "file",
 				Path:        "/data/log/mongodb.log",
 			},
+			SetParameter: &map[string]interface{}{
+				"param": "param",
+			},
 		},
 		AuthSchemaVersion:           5,
 		Disabled:                    false,
@@ -278,3 +296,60 @@ func Test_newReplicaSetProcess(t *testing.T) {
 	got := newReplicaSetProcess(p, "myReplicaSet")
 	assert.Equal(t, got, want)
 }
+
+func Test_newMongosProcessConfig(t *testing.T) {
+	p := &opsmngr.Process{
+		Args26: opsmngr.Args26{
+			NET: opsmngr.Net{
+				Port: 27017,
+			},
+			SystemLog: opsmngr.SystemLog{
+				Destination: "file",
+				Path:        "/data/mongos/mongodb.log",
+			},
+			SetParameter: &map[string]interface{}{
+				"param": "param",
+			},
+			AuditLog: &opsmngr.AuditLog{
+				Path:        "/data/mongos/audit.log",
+				Destination: "file",
+				Format:      "JSON",
+				Filter:      "{ atype: { $in: [ \"createCollection\", \"dropCollection\" ] } }",
+			},
+		},
+		AuthSchemaVersion:           5,
+		Cluster:                     "myCluster",
+		Disabled:                    false,
+		FeatureCompatibilityVersion: "3.6",
+		Hostname:                    "n1.omansible.int",
+		LogRotate: &opsmngr.LogRotate{
+			SizeThresholdMB:  1000,
+			TimeThresholdHrs: 24,
+		},
+		ManualMode:  false,
+		Name:        "myCluster_mongos_4",
+		ProcessType: "mongos",
+		Version:     "3.6.21-ent",
+	}
+
+	want := &ProcessConfig{
+		AuditLogPath:        "/data/mongos/audit.log",
+		AuditLogDestination: "file",
+		AuditLogFormat:      "JSON",
+		AuditLogFilter:      "{ atype: { $in: [ \"createCollection\", \"dropCollection\" ] } }",
+		FCVersion:           "3.6",
+		Hostname:            "n1.omansible.int",
+		LogDestination:      "file",
+		LogPath:             "/data/mongos/mongodb.log",
+		Name:                "myCluster_mongos_4",
+		Port:                27017,
+		ProcessType:         "mongos",
+		Version:             "3.6.21-ent",
+		Disabled:            false,
+		SetParameter: &map[string]interface{}{
+			"param": "param",
+		},
+	}
+	got := newMongosProcessConfig(p)
+	assert.Equal(t, got, want)
+}