CLOUDP-73727: mongocli ops-manager admin backup fileSystem(s) delete (#482)

Author: andreaangiolillo

internal/cli/opsmanager/admin/backup/filesystem/delete.go

@@ -0,0 +1,66 @@
+// Copyright 2020 MongoDB Inc
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package filesystem
+
+import (
+	"github.com/mongodb/mongocli/internal/cli"
+	"github.com/mongodb/mongocli/internal/config"
+	"github.com/mongodb/mongocli/internal/flag"
+	"github.com/mongodb/mongocli/internal/store"
+	"github.com/mongodb/mongocli/internal/usage"
+	"github.com/spf13/cobra"
+)
+
+type DeleteOpts struct {
+	*cli.DeleteOpts
+	store store.FileSystemsDeleter
+}
+
+func (opts *DeleteOpts) init() error {
+	var err error
+	opts.store, err = store.New(config.Default())
+	return err
+}
+
+func (opts *DeleteOpts) Run() error {
+	return opts.Delete(opts.store.DeleteFileSystem)
+}
+
+// // mongocli ops-manager admin backup fileSystem(s) delete <ID> [--force]
+func DeleteBuilder() *cobra.Command {
+	opts := &DeleteOpts{
+		DeleteOpts: cli.NewDeleteOpts("File system configuration '%s' deleted\n", "File system configuration not deleted"),
+	}
+	cmd := &cobra.Command{
+		Use:     "delete <ID>",
+		Aliases: []string{"rm"},
+		Short:   delete,
+		Args:    cobra.ExactArgs(1),
+		PreRunE: func(cmd *cobra.Command, args []string) error {
+			if err := opts.init(); err != nil {
+				return err
+			}
+			opts.Entry = args[0]
+			return opts.Prompt()
+		},
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return opts.Run()
+		},
+	}
+
+	cmd.Flags().BoolVar(&opts.Confirm, flag.Force, false, usage.Force)
+
+	return cmd
+}

internal/cli/opsmanager/admin/backup/filesystem/delete_test.go

@@ -0,0 +1,59 @@
+// Copyright 2020 MongoDB Inc
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// +build unit
+
+package filesystem
+
+import (
+	"testing"
+
+	"github.com/golang/mock/gomock"
+	"github.com/mongodb/mongocli/internal/cli"
+	"github.com/mongodb/mongocli/internal/flag"
+	"github.com/mongodb/mongocli/internal/mocks"
+)
+
+func TestDelete_Run(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	mockStore := mocks.NewMockFileSystemsDeleter(ctrl)
+	defer ctrl.Finish()
+
+	mockStore.
+		EXPECT().
+		DeleteFileSystem(gomock.Eq("5a0a1e7e0f2912c554080adc")).
+		Return(nil).
+		Times(1)
+
+	opts := &DeleteOpts{
+		store: mockStore,
+		DeleteOpts: &cli.DeleteOpts{
+			Entry:   "5a0a1e7e0f2912c554080adc",
+			Confirm: true,
+		},
+	}
+	err := opts.Run()
+	if err != nil {
+		t.Fatalf("Run() unexpected error: %v", err)
+	}
+}
+
+func TestDeleteBuilder(t *testing.T) {
+	cli.CmdValidator(
+		t,
+		DeleteBuilder(),
+		0,
+		[]string{flag.Force},
+	)
+}

internal/cli/opsmanager/admin/backup/filesystem/description.go

@@ -17,4 +17,5 @@ const (
 	short    = "Manage file system configurations."
 	list     = "List file system configurations."
 	describe = "Get a file system configuration."
+	delete   = "Delete a file system configuration."
 )

internal/cli/opsmanager/admin/backup/filesystem/file_system.go

@@ -30,6 +30,7 @@ func Builder() *cobra.Command {
 	cmd.AddCommand(
 		ListBuilder(),
 		DescribeBuilder(),
+		DeleteBuilder(),
 	)
 
 	return cmd

internal/cli/opsmanager/admin/backup/filesystem/file_system_test.go

@@ -25,7 +25,7 @@ func TestFileSystemBuilder(t *testing.T) {
 	cli.CmdValidator(
 		t,
 		Builder(),
-		2,
+		3,
 		[]string{},
 	)
 }

internal/mocks/mock_backup_file_systems.go

@@ -23,7 +23,7 @@ import (
 	"go.mongodb.org/ops-manager/opsmngr"
 )
 
-//go:generate mockgen -destination=../mocks/mock_backup_file_systems.go -package=mocks github.com/mongodb/mongocli/internal/store FileSystemsLister,FileSystemsDescriber
+//go:generate mockgen -destination=../mocks/mock_backup_file_systems.go -package=mocks github.com/mongodb/mongocli/internal/store FileSystemsLister,FileSystemsDescriber,FileSystemsDeleter
 
 type FileSystemsLister interface {
 	ListFileSystems(*atlas.ListOptions) (*opsmngr.FileSystemStoreConfigurations, error)
@@ -33,6 +33,10 @@ type FileSystemsDescriber interface {
 	DescribeFileSystem(string) (*opsmngr.FileSystemStoreConfiguration, error)
 }
 
+type FileSystemsDeleter interface {
+	DeleteFileSystem(string) error
+}
+
 // ListFileSystems encapsulates the logic to manage different cloud providers
 func (s *Store) ListFileSystems(options *atlas.ListOptions) (*opsmngr.FileSystemStoreConfigurations, error) {
 	switch s.service {
@@ -54,3 +58,14 @@ func (s *Store) DescribeFileSystem(fileSystemID string) (*opsmngr.FileSystemStor
 		return nil, fmt.Errorf("unsupported service: %s", s.service)
 	}
 }
+
+// DeleteFileSystem encapsulates the logic to manage different cloud providers
+func (s *Store) DeleteFileSystem(fileSystemID string) error {
+	switch s.service {
+	case config.OpsManagerService:
+		_, err := s.client.(*opsmngr.Client).FileSystemStoreConfig.Delete(context.Background(), fileSystemID)
+		return err
+	default:
+		return fmt.Errorf("unsupported service: %s", s.service)
+	}
+}