Skip to content

Commit f29c7b1

Browse files
authored
PYTHON-5315 Mark test_recover_from_initially_erroring_seedlist as flaky (#2424)
1 parent 04f2cc0 commit f29c7b1

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

test/asynchronous/test_cursor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1411,7 +1411,7 @@ async def test_to_list_length(self):
14111411
async def test_to_list_csot_applied(self):
14121412
client = await self.async_single_client(timeoutMS=500, w=1)
14131413
coll = client.pymongo.test
1414-
# Initialize the client with a larger timeout to help make test less flakey
1414+
# Initialize the client with a larger timeout to help make test less flaky
14151415
with pymongo.timeout(10):
14161416
await coll.insert_many([{} for _ in range(5)])
14171417
cursor = coll.find({"$where": delay(1)})
@@ -1453,7 +1453,7 @@ async def test_command_cursor_to_list_length(self):
14531453
async def test_command_cursor_to_list_csot_applied(self):
14541454
client = await self.async_single_client(timeoutMS=500, w=1)
14551455
coll = client.pymongo.test
1456-
# Initialize the client with a larger timeout to help make test less flakey
1456+
# Initialize the client with a larger timeout to help make test less flaky
14571457
with pymongo.timeout(10):
14581458
await coll.insert_many([{} for _ in range(5)])
14591459
fail_command = {

test/asynchronous/test_retryable_reads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class TestPoolPausedError(AsyncIntegrationTest):
8787
async def test_pool_paused_error_is_retryable(self):
8888
if "PyPy" in sys.version:
8989
# Tracked in PYTHON-3519
90-
self.skipTest("Test is flakey on PyPy")
90+
self.skipTest("Test is flaky on PyPy")
9191
cmap_listener = CMAPListener()
9292
cmd_listener = OvertCommandListener()
9393
client = await self.async_rs_or_single_client(

test/asynchronous/test_srv_polling.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ def empty_seedlist():
262262

263263
await self._test_recover_from_initial(empty_seedlist)
264264

265+
@flaky(reason="PYTHON-5315")
265266
async def test_recover_from_initially_erroring_seedlist(self):
266267
def erroring_seedlist():
267268
raise ConfigurationError

test/test_cursor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,7 +1402,7 @@ def test_to_list_length(self):
14021402
def test_to_list_csot_applied(self):
14031403
client = self.single_client(timeoutMS=500, w=1)
14041404
coll = client.pymongo.test
1405-
# Initialize the client with a larger timeout to help make test less flakey
1405+
# Initialize the client with a larger timeout to help make test less flaky
14061406
with pymongo.timeout(10):
14071407
coll.insert_many([{} for _ in range(5)])
14081408
cursor = coll.find({"$where": delay(1)})
@@ -1444,7 +1444,7 @@ def test_command_cursor_to_list_length(self):
14441444
def test_command_cursor_to_list_csot_applied(self):
14451445
client = self.single_client(timeoutMS=500, w=1)
14461446
coll = client.pymongo.test
1447-
# Initialize the client with a larger timeout to help make test less flakey
1447+
# Initialize the client with a larger timeout to help make test less flaky
14481448
with pymongo.timeout(10):
14491449
coll.insert_many([{} for _ in range(5)])
14501450
fail_command = {

test/test_retryable_reads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ class TestPoolPausedError(IntegrationTest):
8787
def test_pool_paused_error_is_retryable(self):
8888
if "PyPy" in sys.version:
8989
# Tracked in PYTHON-3519
90-
self.skipTest("Test is flakey on PyPy")
90+
self.skipTest("Test is flaky on PyPy")
9191
cmap_listener = CMAPListener()
9292
cmd_listener = OvertCommandListener()
9393
client = self.rs_or_single_client(

test/test_srv_polling.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ def empty_seedlist():
262262

263263
self._test_recover_from_initial(empty_seedlist)
264264

265+
@flaky(reason="PYTHON-5315")
265266
def test_recover_from_initially_erroring_seedlist(self):
266267
def erroring_seedlist():
267268
raise ConfigurationError

0 commit comments

Comments
 (0)