PHPLIB-336: Split out session command option in createIndex()

Author: jmikola

src/Collection.php

@@ -285,8 +285,9 @@ public function count($filter = [], array $options = [])
      */
     public function createIndex($key, array $options = [])
     {
-        $indexOptions = array_diff_key($options, ['maxTimeMS' => 1, 'writeConcern' => 1]);
-        $commandOptions = array_intersect_key($options, ['maxTimeMS' => 1, 'writeConcern' => 1]);
+        $commandOptionKeys = ['maxTimeMS' => 1, 'session' => 1, 'writeConcern' => 1];
+        $indexOptions = array_diff_key($options, $commandOptionKeys);
+        $commandOptions = array_intersect_key($options, $commandOptionKeys);
 
         return current($this->createIndexes([['key' => $key] + $indexOptions], $commandOptions));
     }

tests/Collection/CollectionFunctionalTest.php

@@ -9,6 +9,8 @@
 use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Operation\MapReduce;
+use MongoDB\Tests\CommandObserver;
+use stdClass;
 
 /**
  * Functional tests for the Collection class.
@@ -100,6 +102,35 @@ public function testGetNamespace()
         $this->assertEquals($this->getNamespace(), $this->collection->getNamespace());
     }
 
+    public function testCreateIndexSplitsCommandOptions()
+    {
+        if (version_compare($this->getServerVersion(), '3.6.0', '<')) {
+            $this->markTestSkipped('Sessions are not supported');
+        }
+
+        (new CommandObserver)->observe(
+            function() {
+                $this->collection->createIndex(
+                    ['x' => 1],
+                    [
+                        'maxTimeMS' => 1000,
+                        'session' => $this->manager->startSession(),
+                        'sparse' => true,
+                        'unique' => true,
+                        'writeConcern' => new WriteConcern(1),
+                    ]
+                );
+            },
+            function(stdClass $command) {
+                $this->assertObjectHasAttribute('lsid', $command);
+                $this->assertObjectHasAttribute('maxTimeMS', $command);
+                $this->assertObjectHasAttribute('writeConcern', $command);
+                $this->assertObjectHasAttribute('sparse', $command->indexes[0]);
+                $this->assertObjectHasAttribute('unique', $command->indexes[0]);
+            }
+        );
+    }
+
     public function testDrop()
     {
         $writeResult = $this->collection->insertOne(['x' => 1]);