CXX-196 CXX-155 Force construction of bool to deal with explicit operator bool on streams

(cherry picked from commit 9f28c08)

Author: acmorrow

src/mongo/logger/rotatable_file_writer_test.cpp

@@ -49,21 +49,21 @@ namespace {
             RotatableFileWriter writer;
             RotatableFileWriter::Use writerUse(&writer);
             ASSERT_OK(writerUse.setFileName(logFileName, false));
-            ASSERT_TRUE(writerUse.stream() << "Level 1 message." << std::endl);
-            ASSERT_TRUE(writerUse.stream() << "Level 2 message." << std::endl);
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 1 message." << std::endl));
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 2 message." << std::endl));
             ASSERT_OK(writerUse.rotate(logFileNameRotated));
-            ASSERT_TRUE(writerUse.stream() << "Level 3 message." << std::endl);
-            ASSERT_TRUE(writerUse.stream() << "Level 4 message." << std::endl);
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 3 message." << std::endl));
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 4 message." << std::endl));
         }
 
         {
             std::ifstream ifs(logFileNameRotated.c_str());
             ASSERT_TRUE(ifs.is_open());
             ASSERT_TRUE(ifs.good());
             std::string input;
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 1 message.");
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 2 message.");
             ASSERT_TRUE(std::getline(ifs, input).fail());
             ASSERT_TRUE(ifs.eof());
@@ -74,9 +74,9 @@ namespace {
             ASSERT_TRUE(ifs.is_open());
             ASSERT_TRUE(ifs.good());
             std::string input;
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 3 message.");
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 4 message.");
             ASSERT_TRUE(std::getline(ifs, input).fail());
             ASSERT_TRUE(ifs.eof());
@@ -86,22 +86,22 @@ namespace {
             RotatableFileWriter writer;
             RotatableFileWriter::Use writerUse(&writer);
             ASSERT_OK(writerUse.setFileName(logFileName, true));
-            ASSERT_TRUE(writerUse.stream() << "Level 5 message." << std::endl);
-            ASSERT_TRUE(writerUse.stream() << "Level 6 message." << std::endl);
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 5 message." << std::endl));
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 6 message." << std::endl));
         }
 
        {
             std::ifstream ifs(logFileName.c_str());
             ASSERT_TRUE(ifs.is_open());
             ASSERT_TRUE(ifs.good());
             std::string input;
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 3 message.");
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 4 message.");
             ASSERT_FALSE(std::getline(ifs, input).fail());
             ASSERT_EQUALS(input, "Level 5 message.");
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 6 message.");
             ASSERT_TRUE(std::getline(ifs, input).fail());
             ASSERT_TRUE(ifs.eof());
@@ -111,16 +111,16 @@ namespace {
             RotatableFileWriter writer;
             RotatableFileWriter::Use writerUse(&writer);
             ASSERT_OK(writerUse.setFileName(logFileName, false));
-            ASSERT_TRUE(writerUse.stream() << "Level 7 message." << std::endl);
-            ASSERT_TRUE(writerUse.stream() << "Level 8 message." << std::endl);
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 7 message." << std::endl));
+            ASSERT_TRUE(bool(writerUse.stream() << "Level 8 message." << std::endl));
         }
 
         {
             std::ifstream ifs(logFileName.c_str());
             ASSERT_TRUE(ifs.is_open());
             ASSERT_TRUE(ifs.good());
             std::string input;
-            ASSERT_TRUE(std::getline(ifs, input));
+            ASSERT_TRUE(bool(std::getline(ifs, input)));
             ASSERT_EQUALS(input, "Level 7 message.");
             ASSERT_FALSE(std::getline(ifs, input).fail());
             ASSERT_EQUALS(input, "Level 8 message.");