CDRIVER-703 update mongoc_collection_get_last_error doc

Author: ajdavis

doc/mongoc_collection_get_last_error.page

@@ -26,7 +26,7 @@ mongoc_collection_get_last_error (const mongoc_collection_t *collection);
 
   <section id="description">
     <title>Description</title>
-    <p>The mongoc_collection_get_last_error() function shall return getLastError document, according to write_concern on last executed command for current collection instance.</p>
+    <p>The mongoc_collection_get_last_error() function returns a bulk result. See <link xref="bulk">Bulk Write Operations</link> for examples of bulk results.</p>
     <p>A write_concern must be at least <code>MONGOC_WRITE_CONCERN_W_DEFAULT</code> in last command execution for this to be available.</p>
   </section>
 

doc/mongoc_collection_insert.page

@@ -35,8 +35,7 @@ mongoc_collection_insert (mongoc_collection_t          *collection,
   <section id="description">
     <title>Description</title>
     <p>This function shall insert <code>document</code> into <code>collection</code>.</p>
-    <p>If no <code>_id</code> element is found in <code>document</code>, then a <code xref="bson:bson_oid_t">bson_oid_t</code> will be generated locally and added to the document.</p>
-    <p>You can retrieve a generated <code>_id</code> from <code xref="mongoc_collection_get_last_error">mongoc_collection_get_last_error()</code>.</p>
+    <p>If no <code>_id</code> element is found in <code>document</code>, then a <code xref="bson:bson_oid_t">bson_oid_t</code> will be generated locally and added to the document. If you must know the inserted document's <code>_id</code>, generate it in your code and include it as the first field of <code>document</code>. The <code>_id</code> you generate can be a <code xref="bson:bson_oid_t">bson_oid_t</code> or any other non-array BSON type.</p>
   </section>
 
   <section id="errors">

src/mongoc/mongoc-collection.c

@@ -2014,8 +2014,7 @@ mongoc_collection_get_name (mongoc_collection_t *collection)
  *
  * mongoc_collection_get_last_error --
  *
- *       Returns getLastError document, according to write_concern on last
- *       executed command for current collection instance.
+ *       Returns a bulk result.
  *
  * Returns:
  *       NULL or a bson_t that should not be modified or freed. This value

tests/test-mongoc-collection.c

@@ -819,7 +819,6 @@ _test_legacy_bulk_insert (const bson_t **bsons,
    gle = mongoc_collection_get_last_error (collection);
    assert (gle);
 
-   /* TODO: should contain inserted ids, CDRIVER-703 */
    ASSERT_MATCH (gle, gle_json_formatted);
 
    future_destroy (future);