Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failFast needs to be within requireEncoding tag #271

Closed
henrik242 opened this issue Sep 18, 2023 · 1 comment · Fixed by #291
Closed

failFast needs to be within requireEncoding tag #271

henrik242 opened this issue Sep 18, 2023 · 1 comment · Fixed by #291
Assignees
@slawekjaranowski

Comments

@henrik242
Copy link

henrik242 commented Sep 18, 2023 •
edited
Loading

The documentation shows failFast within the configuration tag:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                </requireEncoding>
              </rules>
              <fastFail>false</fastFail>
            </configuration>

This doesn't work. failFast needs to be with requireEncoding to show all failing files:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                  <fastFail>false</fastFail>
                </requireEncoding>
              </rules>
            </configuration>
@slawekjaranowski
Copy link
Member

You right - PR are welcome

@slawekjaranowski slawekjaranowski self-assigned this Mar 10, 2024
slawekjaranowski added a commit that referenced this issue Mar 10, 2024
@slawekjaranowski
Fix #271 - requireEncoding documentations
88f18c4
@slawekjaranowski slawekjaranowski linked a pull request Mar 10, 2024 that will close this issue
Fix #271 - requireEncoding documentations #291
Merged
slawekjaranowski added a commit that referenced this issue Mar 10, 2024
@slawekjaranowski
Fix #271 - requireEncoding documentations
a708cff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slawekjaranowski slawekjaranowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #271 - requireEncoding documentations mojohaus/extra-enforcer-rules
2 participants
@henrik242 @slawekjaranowski