Use isNotEmpty() instead of !isEmpty()

Author: strongly-typed

src/modm/communication/rpr/interface_impl.hpp

@@ -467,7 +467,7 @@ template <typename Device, std::size_t N>
 void
 modm::rpr::Interface<Device, N>::popMessage(Queue &queue)
 {
-	if (!queue.isEmpty())
+	if (queue.isNotEmpty())
 	{
 		// deallocate the external buffer
 		Message message = queue.get();

src/modm/communication/xpcc/backend/can/connector_impl.hpp

@@ -123,7 +123,7 @@ xpcc::CanConnector<Driver>::sendWaitingMessages()
 	}
 	else if (canDriver->getBusState() != Driver::BusState::Connected) {
 		// No connection to the CAN bus, drop all messages which should be send
-		while (!sendList.isEmpty()) {
+		while (sendList.isNotEmpty()) {
 			sendList.removeFront();
 		}
 		return;

src/modm/container/doubly_linked_list.hpp

@@ -42,6 +42,9 @@ namespace modm
 		inline bool
 		isEmpty() const;
 
+		inline bool
+		isNotEmpty() const { return (not isEmpty()); }
+
 		/**
 		 * \brief	Get number of items in the list
 		 *

src/modm/container/dynamic_array.hpp

@@ -104,6 +104,12 @@ namespace modm
 			return (this->size == 0);
 		}
 
+		inline bool
+		isNotEmpty() const
+		{
+			return not isEmpty();
+		}
+
 		/**
 		 * \brief	Return size
 		 *

src/modm/container/linked_list.hpp

@@ -50,6 +50,9 @@ namespace modm
 		inline bool
 		isEmpty() const;
 
+		inline bool
+		isNotEmpty() const { return (not isEmpty()); }
+
 		/**
 		 * \brief	Get number of elements
 		 *

src/modm/container/linked_list_impl.hpp

@@ -179,7 +179,7 @@ template <typename T, typename Allocator>
 void
 modm::LinkedList<T, Allocator>::removeAll()
 {
-	while (!this->isEmpty()) {
+	while (this->isNotEmpty()) {
 		this->removeFront();
 	}
 }

src/modm/container/stack.hpp

@@ -47,6 +47,12 @@ namespace modm
 			return c.isEmpty();
 		}
 
+		inline bool
+		isNotEmpty()
+		{
+			return not c.isEmpty();
+		}
+
 		bool
 		isFull()
 		{

src/modm/platform/can/lpc/c_can.cpp.in

@@ -162,7 +162,7 @@ modm::platform::Can::CAN_tx(uint8_t /* msg_obj_num */)
 		// All message objects empty. Otherwise the order of messages
 		// is not maintained
 
-		while (!txQueue.isEmpty())
+		while (txQueue.isNotEmpty())
 		{
 			// Still messages in the queue.
 
@@ -349,7 +349,7 @@ bool
 modm::platform::Can::isMessageAvailable()
 {
 %% if options["buffer.rx"] > 0
-	return !rxQueue.isEmpty();
+	return rxQueue.isNotEmpty();
 %% else
 	/* Check if new data is available in the Message
 	 * Objects 1 to 16. */

src/modm/platform/i2c/stm32/i2c_master.cpp.in

@@ -622,7 +622,7 @@ modm::platform::I2cMaster{{ id }}::reset()
 	if (transaction) transaction->detaching(DetachCause::ErrorCondition);
 	transaction = nullptr;
 	// remove all queued transactions
-	while(!queue.isEmpty())
+	while(queue.isNotEmpty())
 	{
 		ConfiguredTransaction next = queue.get();
 		if (next.transaction) next.transaction->detaching(DetachCause::ErrorCondition);

src/modm/platform/uart/at90_tiny_mega/uart_rx.cpp.in

@@ -101,7 +101,7 @@ std::size_t
 modm::platform::Uart{{ id }}::discardReceiveBuffer()
 {
 	std::size_t i(0);
-	while(!rxBuffer.isEmpty())
+	while(rxBuffer.isNotEmpty())
 	{
 		rxBuffer.pop();
 		++i;