fixed and unified getLenght() and getLengthSquared()

Author: TomSaw

src/modm/math/geometry/vector.hpp

@@ -20,6 +20,8 @@
 #include <modm/math/matrix.hpp>
 #include <modm/math/utils/arithmetic_traits.hpp>
 
+#include "geometric_traits.hpp"
+
 namespace modm
 {
 	// forward declaration

src/modm/math/geometry/vector1.hpp

@@ -73,7 +73,7 @@ namespace modm
 		Vector& operator /= (const T &rhs);
 
 		T getLength() const;
-		T getLengthSquared() const;
+		WideType getLengthSquared() const;
 
 		Matrix<T, 1, 1>&
 		asMatrix();

src/modm/math/geometry/vector1_impl.hpp

@@ -142,10 +142,10 @@ modm::Vector<T, 1>::getLength() const
 }
 
 template<typename T>
-T
+modm::Vector<T, 1>::WideType
 modm::Vector<T, 1>::getLengthSquared() const
 {
-	return x * x;
+	return std::pow(x, 2);
 }
 
 // ----------------------------------------------------------------------------

src/modm/math/geometry/vector2_impl.hpp

@@ -23,20 +23,14 @@ template<typename T>
 T
 modm::Vector<T, 2>::getLength() const
 {
-	float tx = this->x;
-	float ty = this->y;
-
-	return GeometricTraits<T>::round(std::sqrt(tx*tx + ty*ty));
+	return GeometricTraits<T>::round(std::sqrt(getLengthSquared()));
 }
 
 template<typename T>
 typename modm::Vector<T, 2>::WideType
 modm::Vector<T, 2>::getLengthSquared() const
 {
-	WideType tx = static_cast<WideType>(this->x);
-	WideType ty = static_cast<WideType>(this->y);
-
-	return tx * tx + ty * ty;
+	return std::pow(x, 2) + std::pow(y, 2);
 }
 
 template<typename T>

src/modm/math/geometry/vector3_impl.hpp

@@ -169,7 +169,7 @@ template<typename T>
 float
 modm::Vector<T, 3>::getLengthSquared() const
 {
-	return x*x+y*y+z*z;
+	return std::pow(x, 2) + std::pow(y, 2) + std::pow(z, 2);
 }
 
 template<typename T>

src/modm/math/geometry/vector4_impl.hpp

@@ -166,7 +166,7 @@ template<typename T>
 float
 modm::Vector<T, 4>::getLengthSquared() const
 {
-	return x*x + y*y + z*z + w*w;
+	return std::pow(x, 2) + std::pow(y, 2) + std::pow(z, 2) + std::pow(w, 2);
 }
 
 template<typename T>