Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'color' variable name from color to COLOR #41

Open
3 tasks
woorim960 opened this issue Oct 29, 2022 · 2 comments
Open
3 tasks

Update the 'color' variable name from color to COLOR #41

woorim960 opened this issue Oct 29, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers refactor Code refactoring

Comments

@woorim960
Copy link
Collaborator

woorim960 commented Oct 29, 2022

Description

Please update the color variable name from color to COLOR.
because we think color variable should updated to the static variable name. it should be updated the name to COLOR for developers so that it understandable easier.

Progress

  • Update variable names in client/app/src/App.tsx
  • Update variable names in client/app/src/common/style/theme.tsx
  • Update variable names in client/app/src/common/instroduction/*

Reference

You can check the color variable name the following link :

import color from "./common/style/theme";

@woorim960 woorim960 added good first issue Good for newcomers refactor Code refactoring labels Oct 29, 2022
@Capalotty
Copy link

could you please asssing to me this issue??

@woorim960
Copy link
Collaborator Author

woorim960 commented Nov 5, 2022

I'm glad to see @Capalotty. Of course.
I've assigned you to the person in charge.

If you send me the PR after the development is completed, I will review it.
Thank you very much for joining us on this project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Code refactoring
Projects
None yet
Development

No branches or pull requests

2 participants