Skip to content

Conversation

@suluyana
Copy link
Collaborator

@suluyana suluyana commented Sep 4, 2025

image

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @suluyana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the LLM capabilities by integrating Anthropic models, allowing the system to leverage another powerful AI provider. Alongside this new feature, a minor refactoring was performed to centralize a shared configuration constant, improving code reusability and maintainability across different LLM modules.

Highlights

  • New Anthropic LLM Integration: Introduced a new module ms_agent/llm/anthropic_llm.py to support Anthropic Large Language Models. This includes methods for formatting tools, converting messages to Anthropic's API format, making API calls, and processing responses, including tool calls.
  • Refactoring of MAX_CONTINUE_RUNS: The MAX_CONTINUE_RUNS constant has been moved from ms_agent/llm/openai_llm.py to a more central location in ms_agent/utils/__init__.py. This makes the constant accessible across different LLM implementations and promotes better code organization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Anthropic LLMs by creating a new Anthropic class that wraps the Anthropic API. The implementation correctly formats messages and tools for the API. Additionally, it refactors the MAX_CONTINUE_RUNS constant to a central location, which is a good improvement. My review focuses on the new anthropic_llm.py file, where I've identified some areas for improvement, including an unimplemented streaming feature, some unused code, and inconsistencies in docstring languages. Addressing these points will help finalize this new feature.

@wangxingjun778 wangxingjun778 merged commit e97117e into modelscope:main Sep 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants