Repository navigation
Commit 5ba7060
committed
Strip stdio frames as bytes
## Motivation and Context
`StdioTransport` reads `$stdin` as UTF-8 and strips each frame before parsing it, in the read loop of `#open`
and in the loop of `#send_request` that reads the client's reply. `String#strip` raises for a UTF-8 string holding
an invalid byte at either end on every supported Ruby, and anywhere in it from Ruby 3.2 on,
and nothing rescued it there: one frame such as `\xff[]`, or a request with an invalid byte in a string value,
ended the read loop and the server process, before the parser could answer it. JSON text must be UTF-8
(RFC 8259, section 8.1), and the Python SDK replaces such bytes on its stdio streams instead of stopping.
Frames are now stripped as bytes. A frame that is not JSON gets the `-32700` parse error any other unparsable frame gets,
and a value holding such a byte reaches the handlers, which serve or refuse it as over HTTP.
## How Has This Been Tested?
`test/mcp/server/transports/stdio_transport_test.rb`: a frame starting with an invalid byte, a frame holding one in a value,
and a client reply holding one in a value. Against the previous library all three raise from `String#strip`
(the value tests from Ruby 3.2 on).
## Breaking Changes
None.1 parent 4559336 commit 5ba7060
2 files changed
Lines changed: 82 additions & 2 deletions
File tree
- lib/mcp/server/transports
- test/mcp/server/transports
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
155 | 163 | | |
156 | 164 | | |
157 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
229 | 272 | | |
230 | 273 | | |
231 | 274 | | |
| |||
295 | 338 | | |
296 | 339 | | |
297 | 340 | | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
298 | 370 | | |
299 | 371 | | |
300 | 372 | | |
| |||
0 commit comments