Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change onClose, onError, onMessage API in Transport to Kotlin-llike #14

Closed
Mr3zee opened this issue Dec 17, 2024 · 0 comments · Fixed by #36
Closed

Change onClose, onError, onMessage API in Transport to Kotlin-llike #14

Mr3zee opened this issue Dec 17, 2024 · 0 comments · Fixed by #36
Assignees
@e5l
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mr3zee
Copy link
Member

Mr3zee commented Dec 17, 2024

This is not Kotlin idiomatic

public var onClose: (() -> Unit)?
@Mr3zee Mr3zee added the enhancement New feature or request label Dec 17, 2024
@e5l e5l added the good first issue Good for newcomers label Jan 7, 2025
e5l added a commit that referenced this issue Jan 14, 2025
@e5l
Migrate to kotlin style callbacks. Close #14
7a55db5
@e5l e5l mentioned this issue Jan 14, 2025
Merged
@e5l e5l self-assigned this Jan 14, 2025
e5l added a commit that referenced this issue Jan 14, 2025
@e5l
Migrate to kotlin style callbacks. Close #14 (#36)
8426228
@e5l e5l closed this as completed in #36 Jan 14, 2025
tinycrops pushed a commit to tinycrops/kotlin-sdk that referenced this issue Mar 8, 2025
@e5l
Migrate to kotlin style callbacks. Close modelcontextprotocol#14 (mod…
3ecd78c 
…elcontextprotocol#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e5l e5l

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to kotlin style callbacks. Close #14 modelcontextprotocol/kotlin-sdk
2 participants
@e5l @Mr3zee