-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
The new CLI interface added by #177 causes a build issue as well as confusion.
The Issue
build-bincurrently creates a change to/bin/cli.jswhich must be reverted.- Probably checking these changes in (they are just whitespace differences) would then set this process straight, but still we are left with a very confusing setup.
The Confusion
- The concept of a build process taking place in a folder called
binwhich is traditionally the output of a build process is inherently confusing. - Previously
bin/cli.jswas the only file in that folder and was what you ran to start the webclient and proxy server. - Now it additionally can start the command line inspector, and contains some .js scripts.
- This is fine, except that there is also a
bin/srcfolder with anindex.tsversion ofcli.jsand apackage.jsonwith a build script that builds this one file tobin/build/index.jsand then copies that tobin/cli.js, generating the set of change above. - There previously was no
clifolder, but now their is. Yet we are maintaining scripts and a build for something else calledcli.jsinbin. - With the introduction of a formal CLI, the naming of
client/bin/cli.jsis also a bit confusing.
To Reproduce
Steps to reproduce the behavior:
- Clone the inspector to your local system
npm run build- Observe
bin/cli.jshas changes
Expected behavior
bin/cli.jsshould not have changes
Also
- All command line stuff should now be in the
clifolder, nobinfolder is required. server,clientandclishould be enough.- The
cli/build/index.jscan decide whether to launch the webclient or do its own thing. No need to have a separatebin/cli.jsthat determines whether to run thecli/build/index.jsor theclient/bin/cli.js client/bin/cli.jsshould be something likeclient/bin/launch.jsfor clarity, since it has nothing to do with the CLI.
Logs
If applicable, add logs to help explain your problem.
Additional context
Add any other context about the problem here.
olaservo, pulkitsharma07 and dabstractor
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working