Audit protocol types (#892)

Author: MackinnonBuck

src/ModelContextProtocol.AspNetCore/StreamableHttpHandler.cs

@@ -250,6 +250,7 @@ private static Task WriteJsonRpcErrorAsync(HttpContext context, string errorMess
     {
         var jsonRpcError = new JsonRpcError
         {
+            Id = default,
             Error = new()
             {
                 Code = errorCode,

src/ModelContextProtocol.Core/AIContentExtensions.cs

@@ -226,6 +226,7 @@ internal static ContentBlock ToContent(this AIContent content) =>
                 {
                     Blob = dataContent.Base64Data.ToString(),
                     MimeType = dataContent.MediaType,
+                    Uri = string.Empty,
                 }
             },
 

src/ModelContextProtocol.Core/Protocol/Annotations.cs

@@ -15,7 +15,7 @@ public sealed class Annotations
     /// Gets or sets the intended audience for this content as an array of <see cref="Role"/> values.
     /// </summary>
     [JsonPropertyName("audience")]
-    public IList<Role>? Audience { get; init; }
+    public IList<Role>? Audience { get; set; }
 
     /// <summary>
     /// Gets or sets a value indicating how important this data is for operating the server.
@@ -25,7 +25,7 @@ public sealed class Annotations
     /// 1 represents highest priority.
     /// </remarks>
     [JsonPropertyName("priority")]
-    public float? Priority { get; init; }
+    public float? Priority { get; set; }
 
     /// <summary>
     /// Gets or sets the moment the resource was last modified.

src/ModelContextProtocol.Core/Protocol/Argument.cs

@@ -15,7 +15,7 @@ public sealed class Argument
     /// Gets or sets the name of the argument being completed.
     /// </summary>
     [JsonPropertyName("name")]
-    public string Name { get; set; } = string.Empty;
+    public required string Name { get; set; }
 
     /// <summary>
     /// Gets or sets the current partial text value for which completion suggestions are requested.
@@ -25,5 +25,5 @@ public sealed class Argument
     /// options should be generated.
     /// </remarks>
     [JsonPropertyName("value")]
-    public string Value { get; set; } = string.Empty;
-}
+    public required string Value { get; set; }
+}

src/ModelContextProtocol.Core/Protocol/BlobResourceContents.cs

@@ -26,5 +26,5 @@ public sealed class BlobResourceContents : ResourceContents
     /// Gets or sets the base64-encoded string representing the binary data of the item.
     /// </summary>
     [JsonPropertyName("blob")]
-    public string Blob { get; set; } = string.Empty;
-}
+    public required string Blob { get; set; }
+}

src/ModelContextProtocol.Core/Protocol/CallToolRequestParams.cs

@@ -14,7 +14,7 @@ public sealed class CallToolRequestParams : RequestParams
 {
     /// <summary>Gets or sets the name of the tool to invoke.</summary>
     [JsonPropertyName("name")]
-    public required string Name { get; init; }
+    public required string Name { get; set; }
 
     /// <summary>
     /// Gets or sets optional arguments to pass to the tool when invoking it on the server.
@@ -24,5 +24,5 @@ public sealed class CallToolRequestParams : RequestParams
     /// a parameter name and its corresponding argument value.
     /// </remarks>
     [JsonPropertyName("arguments")]
-    public IReadOnlyDictionary<string, JsonElement>? Arguments { get; init; }
+    public IDictionary<string, JsonElement>? Arguments { get; set; }
 }

src/ModelContextProtocol.Core/Protocol/CancelledNotificationParams.cs

@@ -20,7 +20,7 @@ public sealed class CancelledNotificationParams : NotificationParams
     /// This must match the ID of an in-flight request that the sender wishes to cancel.
     /// </remarks>
     [JsonPropertyName("requestId")]
-    public RequestId RequestId { get; set; }
+    public required RequestId RequestId { get; set; }
 
     /// <summary>
     /// Gets or sets an optional string describing the reason for the cancellation request.

src/ModelContextProtocol.Core/Protocol/CompleteContext.cs

@@ -15,5 +15,5 @@ public sealed class CompleteContext
     /// Gets or sets previously-resolved variables in a URI template or prompt.
     /// </summary>
     [JsonPropertyName("arguments")]
-    public IDictionary<string, string>? Arguments { get; init; }
+    public IDictionary<string, string>? Arguments { get; set; }
 }

src/ModelContextProtocol.Core/Protocol/CompleteRequestParams.cs

@@ -23,18 +23,18 @@ public sealed class CompleteRequestParams : RequestParams
     /// Gets or sets the reference's information.
     /// </summary>
     [JsonPropertyName("ref")]
-    public required Reference Ref { get; init; }
+    public required Reference Ref { get; set; }
 
     /// <summary>
     /// Gets or sets the argument information for the completion request, specifying what is being completed
     /// and the current partial input.
     /// </summary>
     [JsonPropertyName("argument")]
-    public required Argument Argument { get; init; }
+    public required Argument Argument { get; set; }
 
     /// <summary>
     /// Gets or sets additional, optional context for completions.
     /// </summary>
     [JsonPropertyName("context")]
-    public CompleteContext? Context { get; init; }
+    public CompleteContext? Context { get; set; }
 }

src/ModelContextProtocol.Core/Protocol/ContentBlock.cs

@@ -1,6 +1,7 @@
 using Microsoft.Extensions.AI;
 using System.ComponentModel;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;
 using System.Text.Json.Nodes;
 using System.Text.Json.Serialization;
@@ -33,13 +34,13 @@ private protected ContentBlock()
     }
 
     /// <summary>
-    /// Gets or sets the type of content.
+    /// When overridden in a derived class, gets the type of content.
     /// </summary>
     /// <remarks>
     /// This determines the structure of the content object. Valid values include "image", "audio", "text", "resource", and "resource_link".
     /// </remarks>
     [JsonPropertyName("type")]
-    public string Type { get; set; } = string.Empty;
+    public abstract string Type { get; }
 
     /// <summary>
     /// Gets or sets optional annotations for the content.
@@ -49,7 +50,7 @@ private protected ContentBlock()
     /// and the priority level of the content. Clients can use this information to filter or prioritize content for different roles.
     /// </remarks>
     [JsonPropertyName("annotations")]
-    public Annotations? Annotations { get; init; }
+    public Annotations? Annotations { get; set; }
 
     /// <summary>
     /// Provides a <see cref="JsonConverter"/> for <see cref="ContentBlock"/>.
@@ -276,8 +277,8 @@ public override void Write(Utf8JsonWriter writer, ContentBlock value, JsonSerial
 /// <summary>Represents text provided to or from an LLM.</summary>
 public sealed class TextContentBlock : ContentBlock
 {
-    /// <summary>Initializes the instance of the <see cref="TextContentBlock"/> class.</summary>
-    public TextContentBlock() => Type = "text";
+    /// <inheritdoc/>
+    public override string Type => "text";
 
     /// <summary>
     /// Gets or sets the text content of the message.
@@ -298,8 +299,8 @@ public sealed class TextContentBlock : ContentBlock
 /// <summary>Represents an image provided to or from an LLM.</summary>
 public sealed class ImageContentBlock : ContentBlock
 {
-    /// <summary>Initializes the instance of the <see cref="ImageContentBlock"/> class.</summary>
-    public ImageContentBlock() => Type = "image";
+    /// <inheritdoc/>
+    public override string Type => "image";
 
     /// <summary>
     /// Gets or sets the base64-encoded image data.
@@ -331,8 +332,8 @@ public sealed class ImageContentBlock : ContentBlock
 /// <summary>Represents audio provided to or from an LLM.</summary>
 public sealed class AudioContentBlock : ContentBlock
 {
-    /// <summary>Initializes the instance of the <see cref="AudioContentBlock"/> class.</summary>
-    public AudioContentBlock() => Type = "audio";
+    /// <inheritdoc/>
+    public override string Type => "audio";
 
     /// <summary>
     /// Gets or sets the base64-encoded audio data.
@@ -367,8 +368,8 @@ public sealed class AudioContentBlock : ContentBlock
 /// </remarks>
 public sealed class EmbeddedResourceBlock : ContentBlock
 {
-    /// <summary>Initializes the instance of the <see cref="ResourceLinkBlock"/> class.</summary>
-    public EmbeddedResourceBlock() => Type = "resource";
+    /// <inheritdoc/>
+    public override string Type => "resource";
 
     /// <summary>
     /// Gets or sets the resource content of the message when <see cref="Type"/> is "resource".
@@ -399,20 +400,21 @@ public sealed class EmbeddedResourceBlock : ContentBlock
 /// </remarks>
 public sealed class ResourceLinkBlock : ContentBlock
 {
-    /// <summary>Initializes the instance of the <see cref="ResourceLinkBlock"/> class.</summary>
-    public ResourceLinkBlock() => Type = "resource_link";
+    /// <inheritdoc/>
+    public override string Type => "resource_link";
 
     /// <summary>
     /// Gets or sets the URI of this resource.
     /// </summary>
     [JsonPropertyName("uri")]
-    public required string Uri { get; init; }
+    [StringSyntax(StringSyntaxAttribute.Uri)]
+    public required string Uri { get; set; }
 
     /// <summary>
     /// Gets or sets a human-readable name for this resource.
     /// </summary>
     [JsonPropertyName("name")]
-    public required string Name { get; init; }
+    public required string Name { get; set; }
 
     /// <summary>
     /// Gets or sets a description of what this resource represents.
@@ -431,7 +433,7 @@ public sealed class ResourceLinkBlock : ContentBlock
     /// </para>
     /// </remarks>
     [JsonPropertyName("description")]
-    public string? Description { get; init; }
+    public string? Description { get; set; }
 
     /// <summary>
     /// Gets or sets the MIME type of this resource.
@@ -447,7 +449,7 @@ public sealed class ResourceLinkBlock : ContentBlock
     /// </para>
     /// </remarks>
     [JsonPropertyName("mimeType")]
-    public string? MimeType { get; init; }
+    public string? MimeType { get; set; }
 
     /// <summary>
     /// Gets or sets the size of the raw resource content (before base64 encoding), in bytes, if known.
@@ -456,5 +458,5 @@ public sealed class ResourceLinkBlock : ContentBlock
     /// This can be used by applications to display file sizes and estimate context window usage.
     /// </remarks>
     [JsonPropertyName("size")]
-    public long? Size { get; init; }
-}
+    public long? Size { get; set; }
+}