Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with clang: '-fstrength-reduce' is not supported #5

Open
yurivict opened this issue Aug 4, 2017 · 2 comments
Open

Fails with clang: '-fstrength-reduce' is not supported #5

yurivict opened this issue Aug 4, 2017 · 2 comments

Comments

@yurivict
Copy link

yurivict commented Aug 4, 2017

cc: error: optimization flag '-fstrength-reduce' is not supported [-Werror,-Wignored-optimization-argument]

@tresf
Copy link

tresf commented Dec 6, 2017

This is an upstream bug and should be reported there: https://github.com/tomszilagyi/tap-plugins/blob/master/Makefile#L38, or better yet, send the author a PR.

I just patched this with CMake, I don't know make, so I'll leave the cmake patch here as an example. Note, I'm not sure if strength-reduce has been replaced with something else on the Clang side of the fence, this just blindly removes it.

I've noticed this change occurred (at least on the MacOS version of Clang) between XCode 8.2 and XCode 8.3

# CMAKE EXAMPLE ONLY - ADAPT TO MAKE
IF(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstrength-reduce")
ENDIF()

@tomscii
Copy link

tomscii commented Jan 20, 2019

Fixed in latest upstream master (tomszilagyi/tap-plugins commit 94aeb04).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants