exporter: add tests for a directory with an idmap error#5411
Open
nicks wants to merge 1 commit intomoby:masterfrom
Open
exporter: add tests for a directory with an idmap error#5411nicks wants to merge 1 commit intomoby:masterfrom
nicks wants to merge 1 commit intomoby:masterfrom
Conversation
this test demonstrates the bug called out in tonistiigi/fsutil#203 Currently, if a directory's UID can't be mapped to the host, buildkit will export an invalid tarball. Signed-off-by: Nick Santos <nick.santos@docker.com>
AkihiroSuda
reviewed
Oct 9, 2024
| activeRef, err := cm.Get(ctx, snap.ID(), nil) | ||
| require.NoError(t, err) | ||
|
|
||
| fs, _, err := CreateFS(ctx, sessionID, "k???", activeRef, nil, time.Now(), CreateFSOpts{}) |
Contributor
Author
There was a problem hiding this comment.
i don't know! 😂 i didn't find a good example of what this should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test demonstrates the bug called out in
tonistiigi/fsutil#203
Currently, if a directory's UID can't be mapped to the host, buildkit will export an invalid tarball.