Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink the use of the Hample filter to smooth step times in CAD calculation. #101

Open
AKuederle opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AKuederle
Copy link
Contributor

AKuederle commented Mar 11, 2024

I only quickly took screenshots of the two cases and did not investigate deeper, but basically, I was looking at the Hample filter used for smoothing in the CAD estimation. I had a case, where the input ICs where only shifted by 1 sample, but the output was significantly different. (input in the screenshopts -> ICS, output -> step_time_per_sec_smooth)

The intersting thing is, that in one of the cases the values are basically all the same in the output.
What I think what is happening here, as the Hample filter is calculating the SD over 3 samples and then comparing with the remaining samples, things become difficult, when the SD becomes very low, as this basically means that any other value is considered an outlier and smoothed
So if you have two Cadence values that are identical, it might be that everything collapses, because the STD is to low.
Similar things should also happen for SL as it uses the same type of filter.
I have not verified, if the same thing also happens in the Matlab implementation, but I assume it does.

Screenshot_20240308_192139
Screenshot_20240308_192333

@AKuederle AKuederle added the enhancement New feature or request label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant