-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICA.plot_overlay not useful for average-referenced EEG data #11805
Comments
Thanks for documenting! |
+1 for this -- I'm a bit surprised it's the average because polarity differences between channels would lead to cancellation even without any processing, making it look like activity is small when it could be huge. Something like the standard deviation/GFP seems much more informative. |
+1 for using RMS for MEG and GFP for EEG |
SGTM, @mscheltienne do you want to tackle this one? |
RMS and GFP sounds good. I can add that to my to-do list for next week. |
One more point I have a bit of an hard time to wrap my head around, and I'd prefer to figure it out before starting to change the viz functions of the ICA. What about ICA decomposition on combined MEG/EEG (or any combined data types)? I don't have an issue with a fit on the entire data array at once, but the visualization of the mixing matrix seems misleading.
The code snippet fits 115 components on 204 gradiometers, 102 magnetometers and 60 EEG channels. I can now do
EDIT: Not sure about the independence of sources and how specifically an IC will capture a single channel type. Other issue related to this point: mne-tools/mne-icalabel#133 |
I will add some additional thoughts to my previous comment. If the ICA was fitted on 3 modalites, 204 gradiometers, 102 magnetometers and 60 EEG channels, it is possible to have:
I find misleading to display with One improvement to the topographic plot of a component within Anyway, I am sidetracking quite a bit from the original issue, I got a bit lost in the ICA code.. but I think |
@cbrnr and I ran into a potentially related bug during last week's workshop: |
Seems like the Line 211 in 9b3a4d3
|
@mscheltienne sounds like you are just about ready to open a PR 😄 |
Actually, I just notice that lovely note in the documentation:
So.. not a bug in the end. But I don't really find this solution satisfactory, it's an hidden feature and doesn't allow the creation of a non-interactive plot with the non-default channel type displayed. I'll make a proposition of re-arranged layout with 1 to 3 topographies. |
I would say it is a bug, if I request to see EEG channels but get MAG instead ... then this is not right. |
The lower panel of
ICA.plot_overlay
figures shows a trace of all channels averaged together (before and after ICA). For average-referenced EEG data, the mean of all channels is very very close to zero (on the order of 1e-20 usually) and thus the plot basically shows noise. We should figure out an elegant way to handle this. Possibilities:I haven't thought much about what is the sensible path here, just documenting this so we don't lose track of it.
Related forum post: https://mne.discourse.group/t/ica-plot-overlay-gives-strange-results/7207/10
cc @mscheltienne who did the legwork figuring out what was going on with the user's plots. 🙏🏻
The text was updated successfully, but these errors were encountered: