FIX: More [circle full]

Author: larsoner

mne/decoding/tests/test_base.py

@@ -275,7 +275,12 @@ def test_get_coef_multiclass(n_features, n_targets):
     """Test get_coef on multiclass problems."""
     # Check patterns with more than 1 regressor
     X, Y, A = _make_data(n_samples=30000, n_features=n_features, n_targets=n_targets)
-    lm = LinearModel(LinearRegression()).fit(X, Y)
+    lm = LinearModel(LinearRegression())
+    assert not hasattr(lm, "model_")
+    lm.fit(X, Y)
+    # TODO: modifying non-underscored `model` is a sklearn no-no, maybe should be a
+    # metaestimator?
+    assert lm.model is lm.model_
     assert_array_equal(lm.filters_.shape, lm.patterns_.shape)
     if n_targets == 1:
         want_shape = (n_features,)

mne/decoding/tests/test_time_frequency.py

@@ -35,7 +35,9 @@ def test_timefrequency_basic():
     clone(tf)
 
     # Fit
+    assert not hasattr(tf, "fitted_")
     tf.fit(X, None)
+    assert tf.fitted_
 
     # Transform
     tf = TimeFrequency(freqs, sfreq=100)

mne/decoding/tests/test_transformer.py

@@ -186,7 +186,9 @@ def test_psdestimator():
     epochs_data = epochs.get_data(copy=False)
     psd = PSDEstimator(2 * np.pi, 0, np.inf)
     y = epochs.events[:, -1]
+    assert not hasattr(psd, "fitted_")
     X = psd.fit_transform(epochs_data, y)
+    assert psd.fitted_
 
     assert X.shape[0] == epochs_data.shape[0]
     assert_array_equal(psd.fit(epochs_data, y).transform(epochs_data), X)
@@ -308,7 +310,9 @@ def test_bad_triage():
     filt = TemporalFilter(l_freq=8, h_freq=60, sfreq=160.0)
     # Used to fail with "ValueError: Effective band-stop frequency (135.0) is
     # too high (maximum based on Nyquist is 80.0)"
+    assert not hasattr(filt, "fitted_")
     filt.fit_transform(np.zeros((1, 1, 481)))
+    assert filt.fitted_
 
 
 @pytest.mark.filterwarnings("ignore:.*filter_length.*")

mne/decoding/transformer.py

@@ -461,7 +461,7 @@ def fit(self, epochs_data, y=None):
         self.fitted_ = True  # sklearn compliance
         return self
 
-    def transform(self, epochs_data, y=None):
+    def transform(self, epochs_data):
         """Compute power spectral density (PSD) using a multi-taper method.
 
         Parameters

tools/vulture_allowlist.py

@@ -41,6 +41,8 @@
 
 # Decoding
 _._more_tags
+_.multi_class
+_.preserves_dtype
 deep
 
 # Backward compat or rarely used