-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7 #181
Comments
@adam2392 Sorry for the delay, I was on holiday the last 2 weeks. Yes, I would be very interested! |
seems worth cutting a release now --- not necessarily because of impending GSoC changes, but because it's been ~5 months and there are some useful changes and bugfixes on |
@adam2392 I'm happy to help out if the offer still stands! |
I don't have a walk-thru of how to do this exactly for mne-connectivity, but mne-bids has a writeup on how to do this. We just don't have a few of their steps tho. https://github.com/mne-tools/mne-bids/wiki/How-to-make-a-release Do you want to take a look and see if you can sketch out a sequence of steps that makes sense to you? Once you do it once, you'll have the exp to do it on any package :) |
Let us know if you have questions |
Sounds good, I will try and get this done ASAP. Though it might be worth waiting until #184 is merged since this has some nice efficiency improvements and is unrelated to the GSoC work. Thoughts? |
Sounds good to me! |
WIP in #195 |
@adam2392 One of the steps mentioned in the wiki is uploading to and checking install from test-pypi, but I don't have access. Do you need to do this before moving forward, or is it good enough that the installation in the circleci passes? |
Been a while since I've done this so I just tried and:
|
Rather than do all that I'd rather modernize with trusted artifact publishing on release https://github.com/pypa/gh-action-pypi-publish?tab=readme-ov-file#usage Can start from this and remove the username password stuff, then I can configure trusted publishing on PyPI: https://github.com/mne-tools/mne-bids-pipeline/blob/main/.github/workflows/release.yml @tsbinns if you want to learn how to do CI stuff feel free to open a PR to get the ball rolling. I can do the (pretty easy) config at the PyPI end of things. If you would rather focus on moving on to connectivity I can set up the action instead. |
Sorry for the delay. I had my wedding this past weekend so life was hectic. But I agree that a GH action might make more sense and prevent this workflow issue in the future. |
Awesome congrats! 🎉 Whenever convenient if you could make me an owner rather than maintainer I can do the trusted publishing stuff: https://pypi.org/project/mne-connectivity/ You can also do it if you want (but please do make me an owner either way, it's not recommended to have a single owner of a project): https://docs.pypi.org/trusted-publishers/adding-a-publisher/ |
Congrats @adam2392!
@larsoner Definitely, would be happy to try this. Regarding the existing |
@larsoner Do you want me to create a new maint/0.7 branch and update the built docs in the gh-pages branch? |
@larsoner sorry for the delay! Added you as an owner now. |
I wasn't sure if you had permissions so I went ahead and did these steps. In theory CircleCI should try to push 0.7 to https://mne.tools/mne-connectivity/stable soon! |
A lot of new features courtesy of @tsbinns.
We should aim to make a release. @tsbinns any interest in trying this out?
The text was updated successfully, but these errors were encountered: