Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should pipeline be more flexible about how source space spacing is specified? #1047

Open
drammock opened this issue Jan 28, 2025 · 1 comment

Comments

@drammock
Copy link
Member

drammock commented Jan 28, 2025

in #1045 (comment) I noticed that a source space in a dataset I had was called ...oct-6-src.fif whereas the pipeline was expecting ...oct6-src.fif (note the lack of - between oct and 6). Do either @hoechenberger or @larsoner know whether oct-6 (with the dash) is common enough in the wild to be worth checking for / using if found? Computing source spaces isn't a super long process, but for a large dataset it could add significant time to recreate them all unnecessarily.

@larsoner
Copy link
Member

IIRC oct-6 is an older convention and we've been using oct6 for a while. But I'm fine with being flexible where if oct-6 already exists we could use it (but still always write oct6 if we compute it). Should only require a couple of lines so pretty low maintenance burden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants