Skip to content

Commit 43e7396

Browse files
committed
removed extraneous comments
1 parent c6c9333 commit 43e7396

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

NEWS.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# mlr3torch dev
22

3+
* Added `CallbackSetTB`, which allows logging that can be viewed by TensorBoard.
34
* Don't use deprecated `data_formats` anymore
45

56
# mlr3torch 0.1.1

R/CallbackSetTB.R

-3
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ CallbackSetTB = R6Class("CallbackSetTB",
3030
},
3131
#' @description
3232
#' Logs the training loss and validation measures as TensorFlow events.
33-
# TODO: display the appropriate x axis with its label in TensorBoard
34-
# relevant when we log different scores at different times
3533
on_epoch_end = function() {
3634
if (self$log_train_loss) {
3735
private$.log_train_loss()
@@ -64,7 +62,6 @@ CallbackSetTB = R6Class("CallbackSetTB",
6462
private$.log_score("train.", measure_name, train_score)
6563
},
6664
.log_train_loss = function() {
67-
# TODO: remind ourselves why we wanted to display last_loss and not last_scores_train
6865
with_logdir(self$path, {
6966
log_event(train.loss = self$ctx$last_loss)
7067
})

tests/testthat/test_CallbackSetTB.R

-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ test_that("autotest", {
77

88
# TODO: investigate what's happening when there is only a single epoch (why don't we log anything?)
99
test_that("a simple example works", {
10-
# using a temp dir
1110
cb = t_clbk("tb")
1211

1312
task = tsk("iris")
@@ -53,7 +52,6 @@ test_that("a simple example works", {
5352
})
5453

5554
test_that("eval_freq works", {
56-
# using a temp dir
5755
cb = t_clbk("tb")
5856

5957
task = tsk("iris")

0 commit comments

Comments
 (0)