Skip to content

Commit d5267ad

Browse files
committed
test: better object size estimate
1 parent 52ec1ea commit d5267ad

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

DESCRIPTION

+2-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ Suggests:
4141
ranger,
4242
rpart,
4343
testthat (>= 3.0.0),
44-
xgboost
44+
xgboost,
45+
pryr
4546
Remotes:
4647
catboost/catboost/catboost/R-package,
4748
mlr-org/mlr3,

tests/testthat/test_estimate_memory.R

+8-8
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ task = as_task_classif(dt, target = "y")
1111
test_that("LearnerClassifRanger memory estimate is approximately correct", {
1212
learner = lrn("classif.ranger")
1313
learner$train(task)
14-
true_mem = object.size(learner$model)
14+
true_mem = pryr::object_size(learner$model)
1515
estim_mem = estimate_memory(learner, task)
1616

1717
expect_true(true_mem <= estim_mem)
@@ -20,7 +20,7 @@ test_that("LearnerClassifRanger memory estimate is approximately correct", {
2020
test_that("LearnerClassifXgboost memory estimate is approximately correct", {
2121
learner = lrn("classif.xgboost")
2222
learner$train(task)
23-
true_mem = object.size(learner$model)
23+
true_mem = pryr::object_size(learner$model)
2424
estim_mem = estimate_memory(learner, task)
2525

2626
expect_true(true_mem <= estim_mem)
@@ -29,7 +29,7 @@ test_that("LearnerClassifXgboost memory estimate is approximately correct", {
2929
test_that("LearnerClassifCatboost memory estimate is approximately correct", {
3030
learner = lrn("classif.catboost")
3131
learner$train(task)
32-
true_mem = object.size(learner$model)
32+
true_mem = pryr::object_size(learner$model)
3333
estim_mem = estimate_memory(learner, task)
3434

3535
expect_true(true_mem <= estim_mem)
@@ -38,7 +38,7 @@ test_that("LearnerClassifCatboost memory estimate is approximately correct", {
3838
test_that("LearnerClassifLightGBM memory estimate is approximately correct", {
3939
learner = lrn("classif.lightgbm")
4040
learner$train(task)
41-
true_mem = object.size(learner$model)
41+
true_mem = pryr::object_size(learner$model)
4242
estim_mem = estimate_memory(learner, task)
4343

4444
expect_true(true_mem <= estim_mem)
@@ -52,7 +52,7 @@ task = as_task_regr(dt, target = "y")
5252
test_that("LearnerRegrRanger memory estimate is approximately correct", {
5353
learner = lrn("regr.ranger")
5454
learner$train(task)
55-
true_mem = object.size(learner$model)
55+
true_mem = pryr::object_size(learner$model)
5656
estim_mem = estimate_memory(learner, task)
5757

5858
expect_true(true_mem <= estim_mem)
@@ -61,7 +61,7 @@ test_that("LearnerRegrRanger memory estimate is approximately correct", {
6161
test_that("LearnerRegrXgboost memory estimate is approximately correct", {
6262
learner = lrn("regr.xgboost")
6363
learner$train(task)
64-
true_mem = object.size(learner$model)
64+
true_mem = pryr::object_size(learner$model)
6565
estim_mem = estimate_memory(learner, task)
6666

6767
expect_true(true_mem <= estim_mem)
@@ -70,7 +70,7 @@ test_that("LearnerRegrXgboost memory estimate is approximately correct", {
7070
test_that("LearnerRegrCatboost memory estimate is approximately correct", {
7171
learner = lrn("regr.catboost")
7272
learner$train(task)
73-
true_mem = object.size(learner$model)
73+
true_mem = pryr::object_size(learner$model)
7474
estim_mem = estimate_memory(learner, task)
7575

7676
expect_true(true_mem <= estim_mem)
@@ -79,7 +79,7 @@ test_that("LearnerRegrCatboost memory estimate is approximately correct", {
7979
test_that("LearnerRegrLightGBM memory estimate is approximately correct", {
8080
learner = lrn("regr.lightgbm")
8181
learner$train(task)
82-
true_mem = object.size(learner$model)
82+
true_mem = pryr::object_size(learner$model)
8383
estim_mem = estimate_memory(learner, task)
8484

8585
expect_true(true_mem <= estim_mem)

0 commit comments

Comments
 (0)