refactor: early return

Author: Simon Bigelmayr

src/PHPStan/Rules/ThrowableClassNameRule.php

@@ -21,13 +21,23 @@ public function getNodeType(): string
     public function processNode(Node $node, Scope $scope): array
     {
         $className = (string) $node->name;
-        $extendsThrowable = false;
 
-        if ($node->extends !== null) {
-            $parentClass = $node->extends->toString();
-            $extendsThrowable = is_subclass_of($parentClass, \Throwable::class) || $parentClass === \Throwable::class;
+        if ($node->extends === null) {
+            if (str_ends_with($className, 'Exception')) {
+                return [
+                    RuleErrorBuilder::message(sprintf(
+                        'Class "%s" uses the suffix "Exception" but does not extend \Throwable. Consider using "Exemption" or another term.',
+                        $className
+                    ))->build(),
+                ];
+            }
+
+            return [];
         }
 
+        $parentClass = $node->extends->toString();
+        $extendsThrowable = is_subclass_of($parentClass, \Throwable::class) || $parentClass === \Throwable::class;
+
         if ($extendsThrowable && ! str_ends_with($className, 'Exception')) {
             return [
                 RuleErrorBuilder::message(sprintf(
@@ -37,15 +47,6 @@ public function processNode(Node $node, Scope $scope): array
             ];
         }
 
-        if (! $extendsThrowable && str_ends_with($className, 'Exception')) {
-            return [
-                RuleErrorBuilder::message(sprintf(
-                    'Class "%s" uses the suffix "Exception" but does not extend \Throwable. Consider using "Exemption" or another term.',
-                    $className
-                ))->build(),
-            ];
-        }
-
         return [];
     }
 }