Skip to content

refactor: Defer creating module finder until first load #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2025
Merged

refactor: Defer creating module finder until first load #411

merged 6 commits into from
Oct 10, 2025

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Sep 17, 2025

Works around most cases in #410.

For reviewers

  • I did not use AI
  • I used AI and thorougly reviewed every code/docs change

@johnslavik johnslavik changed the title Defer creating module finder until first load fix: Defer creating module finder until first load Sep 17, 2025
@johnslavik johnslavik changed the title fix: Defer creating module finder until first load refactor: Defer creating module finder until first load Sep 17, 2025
@johnslavik johnslavik marked this pull request as draft September 17, 2025 21:27
@johnslavik
Copy link
Member Author

johnslavik commented Sep 17, 2025 •
edited
Loading

I confirmed the failures are unrelated. See #412

@pawamoy
Copy link
Member

pawamoy commented Sep 18, 2025 •
edited
Loading

Ready for review? Maybe we could add a test since you have a short repro 🙂

@johnslavik
Copy link
Member Author

johnslavik commented Sep 19, 2025

Yeah I'll add a test

@pawamoy pawamoy marked this pull request as ready for review October 10, 2025 16:23
@pawamoy pawamoy merged commit c52dd22 into main Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik @pawamoy