resolved #1 Hide Not Completed pull requests

mkaykisiz · mkaykisiz · commit 2f407294b9d5 · 2019-02-18T23:31:15.000+03:00
diff --git a/content_script.js b/content_script.js
@@ -1,11 +1,28 @@
-chrome.storage.sync.get(['hideReviewers'], function(result) {
-	if(result.hideReviewers){
-		var reviewers = document.querySelectorAll('td.reviewers');
-		Array.prototype.forEach.call(reviewers, function(review) {
-		    // Do stuff here
-		    if(review.getElementsByClassName('badge-hidden').length == 0){
-		    	review.closest('tr').remove();
-			}
-		});
-	}
+let completed_control = false;
+let not_completed_control = false;
+chrome.storage.sync.get(['completed'], function (result) {
+    if (result.completed) {
+        completed_control = true;
+    }
 });
+chrome.storage.sync.get(['not_completed'], function (result) {
+    if (result.not_completed) {
+        not_completed_control = true;
+    }
+});
+
+
+fireReview = () => {
+    var reviewers = document.querySelectorAll('td.reviewers');
+    Array.prototype.forEach.call(reviewers, function (review) {
+        if ((completed_control && review.getElementsByClassName('badge-hidden').length == 0) || (not_completed_control && review.getElementsByClassName('badge-hidden').length > 0)) {
+            review.closest('tr').remove();
+        }
+    });
+};
+
+setInterval(function () {
+    fireReview()
+}, 500);
+
+
diff --git a/default.html b/default.html
@@ -4,12 +4,16 @@
 	<meta charset="utf-8">
 	<title>Hide Completed Review on Bitbucket</title>	
 </head>
-<body>
-
+<body style="min-width: 200px;">
 	<label>
 	  <input type="checkbox" id="hide_completed_prs_checkbox">
 	  Hide completed PRs
 	</label>
+	<br>
+	<label>
+	  <input type="checkbox" id="hide_not_completed_prs_checkbox">
+	  Hide not completed PRs
+	</label>
 	<script src="jquery-3.3.1.min.js"></script>
 	<script src="default.js"></script>
 </body>
diff --git a/default.js b/default.js
@@ -1,33 +1,60 @@
-function setHiddenStatus(){
-    chrome.storage.sync.get(['hideReviewers'], function(result) {
-        document.getElementById('hide_completed_prs_checkbox').checked = result.hideReviewers;
-    });
+function setHiddenStatus(event_type) {
+    if (event_type === 'completed') {
+        chrome.storage.sync.get([event_type], function (result) {
+            document.getElementById('hide_completed_prs_checkbox').checked = result.completed;
+        });
+    } else {
+        chrome.storage.sync.get([event_type], function (result) {
+            document.getElementById('hide_not_completed_prs_checkbox').checked = result.not_completed;
+        });
+    }
 }
 
-function saveChanges() {
+function saveChanges(event_type) {
+    let status = false;
+    let event_item = false;
+
+    if (event_type === 'completed') {
+        event_item = '#hide_completed_prs_checkbox';
+    } else {
+        event_item = '#hide_not_completed_prs_checkbox';
+    }
     // Get a value.
-    if ($('#hide_completed_prs_checkbox').is(':checked')) {
-        xhideReviewers = true;
+    if ($(event_item).is(':checked')) {
+        status = true;
+    }
+    let storage_info = {};
+    if (event_type === 'completed') {
+        storage_info = {'completed': status}
     } else {
-        xhideReviewers = false;
+        storage_info = {'not_completed': status}
     }
+
     // Save it using the Chrome extension storage API.
-    chrome.storage.sync.set({
-        'hideReviewers': xhideReviewers
-    }, function () {});
+    chrome.storage.sync.set(storage_info, function () {
+    });
 
-    setHiddenStatus();
+    setHiddenStatus(event_type);
 
-    chrome.tabs.query({active: true, currentWindow: true}, function(tabs) {
+    chrome.tabs.query({active: true, currentWindow: true}, function (tabs) {
         chrome.tabs.reload(tabs[0].id);
     });
 }
 
-var hide_completed_prs_checkbox = document.getElementById('hide_completed_prs_checkbox');
+const hide_completed_prs_checkbox = document.getElementById('hide_completed_prs_checkbox');
+// onClick's logic below:
+if (hide_completed_prs_checkbox) {
+    setHiddenStatus('completed');
+    hide_completed_prs_checkbox.addEventListener('change', function () {
+        saveChanges('completed');
+    });
+}
+
+const hide_not_completed_prs_checkbox = document.getElementById('hide_not_completed_prs_checkbox');
 // onClick's logic below:
-if(hide_completed_prs_checkbox){
-    setHiddenStatus()
-    hide_completed_prs_checkbox.addEventListener('change', function() {
-        saveChanges();
+if (hide_not_completed_prs_checkbox) {
+    setHiddenStatus('not_completed');
+    hide_not_completed_prs_checkbox.addEventListener('change', function () {
+        saveChanges('not_completed');
     });
 }
