-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no published sdist for 2.4.2 #269
Comments
I confirm https://pypi.org/project/sacrebleu/2.4.2/#files is missing |
Thanks, @martinpopel. The tool we're working with automates builds from sdists, so I thought it was worth checking and I appreciate the quick response. We can do some work to configure it to build from that source archive if we have to, but if you consider it an oversight I may just wait a day or so to see if you have time to upload the sdist. I'd be happy to help you set up a GitHub action for publishing releases from tags, too. I have it configured in several repos, and find it really simplifies things. If you're interested, I could send you a PR and help you debug any issues setting up the authentication. Let me know. |
Hi @dhellmann, this would be great to have. We'd be very grateful you'd contribute a PR and tell us how to make use of the feature. It's one of those things I can never seem to make time for. |
Great, I'll be happy to help. Today is pretty full, but I should have time later this week to prepare a PR for you based on what I do in other repos like this: https://github.com/python-wheel-build/fromager/blob/main/.github/workflows/python-publish.yaml There's a link in the top of that file that points to the GitHub.com docs for publishing python packages. The main thing that I stumbled over when setting up the trusted publishing hook was failing to set the "environment" value. |
I'm trying to prepare a build of sacrebleu from source but there is no sdist on pypi for the 2.4.2 release. Is that an oversight or are you no longer publishing sdists?
The text was updated successfully, but these errors were encountered: