Skip to content

Laravel 5 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glennjacobs opened this issue Sep 24, 2014 · 48 comments
Closed

Laravel 5 #40

glennjacobs opened this issue Sep 24, 2014 · 48 comments

Comments

@glennjacobs
Copy link
Contributor

Laravel 5 has broken compatibility for the UserProvider.

I've fixed it locally, but it will not work with Laravel 4 - how do you want to handle this? Make a branch specifically for Laravel 5?

@kirkbushell
Copy link
Collaborator

Is that because the contracts have been moved onto into their own package now?

@glennjacobs
Copy link
Contributor Author

Yeah, that's precisely it.

@kirkbushell
Copy link
Collaborator

yeah, I thought so.

I can't speak for @mitchellvanw, but I imagine L5 support will probably be put on a separate branch. It'll have to happen soon, because many of us are using 5. hehe

@mitchellvanw
Copy link
Owner

Yes. The moment L5 is out I'll support it. I can't do much about it right now. Sorry

@glennjacobs
Copy link
Contributor Author

OK, I'll make my own branch until then.

@kirkbushell
Copy link
Collaborator

@mitchellvanw we could setup 0.6 to support L5? That way users can just specify 0.6.* as their laravel-doctrine version. Happy to champion this if you like.

@jonesio
Copy link

jonesio commented Sep 24, 2014

Thanks guys. I too have fixed this locally. Can we not maintain a separate branch that supports L5 in the meantime? Agree with kirkbushell.

@hendore
Copy link

hendore commented Sep 24, 2014

+1 for a L5 compatible branch.

@simonhampel
Copy link

+1

1 similar comment
@glennjacobs
Copy link
Contributor Author

👍

@timothycox
Copy link

+1 please, just about to start a project with L5.

@mitchellvanw
Copy link
Owner

@konfine Since Laravel 5 is unstable right now this package won't support it just yet. You will have to wait for the release.

@gustavor
Copy link

I agree with @mitchellvanw. But I'm totally 👍 to have a L5 separated branch too

@glennjacobs
Copy link
Contributor Author

Laravel 5 is going into Beta this week, so does that mean we can start working on compatibility?

@kirkbushell
Copy link
Collaborator

Yeah we'll get started on it very soon :)

@darrencraig
Copy link

I've maintained a fork which currently works with a fresh install of Laravel 5, if it helps anyone until Mitchell & Kirk release something official.

Note: There is currently no way to publish a config file using artisan, so you have to manually copy the vendor/mitchellvanw/laravel-doctrine/config/doctrine.php to /config/doctrine.php

https://github.com/darrencraig/laravel-doctrine

In your composer.json file -

"require": { "mitchellvanw/laravel-doctrine": "dev-develop" },
"repositories": [
{
"type": "vcs",
"url": "https://github.com/darrencraig/laravel-doctrine"
}
]

Good luck :)

@winkbrace
Copy link

Thanks!

@kirkbushell
Copy link
Collaborator

Config publishing has now been resolved, and can be found on the docs: http://laravel.com/docs/master/packages#configuration

We're 1 step closer to getting an L5 branch ready :)

@melloc01
Copy link

melloc01 commented Feb 7, 2015

Cool. Now L5 is out, hope you guys release the compatibility branch soon, thanks 😃

@rreynier
Copy link

👍

@mkbrv
Copy link

mkbrv commented Feb 12, 2015

Any news regarding Laravel 5 compatibility?

@ldebrouwer
Copy link

I'm able to help testing any Laravel 5 compatible work today and tomorrow.

@ArthurGuy
Copy link

+1 Looking forward to this

@DaHaiz
Copy link

DaHaiz commented Feb 22, 2015

push push push :) 👍

@ommartin
Copy link

👍 Any ETA on L5 compatibility?

@dannykopping
Copy link

Submitted a PR which fixes Laravel 5 compatibility:
#113

@FoxxMD
Copy link
Contributor

FoxxMD commented Mar 19, 2015

@melloc01
Copy link

Hey @FoxxMD , sweet, will test it soon 👍

@jwpage jwpage mentioned this issue Mar 25, 2015
@nloding
Copy link

nloding commented Mar 26, 2015

@FoxxMD - been using your fork all day, works brilliantly so far! Here's hoping an official L5 release of laravel-doctrine is around the corner.

@alirezarahmani
Copy link

@FoxxMD
Copy link
Contributor

FoxxMD commented Mar 26, 2015

@nloding Glad it's working for you! 👍 I'm looking forward to the official release too

@alirezarahmani I actually looked at that project when I was initially researching doctrine integration but there is a lack of documentation and no list of included features. @mitchellvanw has both of those and a larger support community (I couldn't have created a L5 fork without all the PRs people have submitted already!)

@ninthspace
Copy link

@FoxxMD: your fork works great for me too, thank you!

@kirkbushell
Copy link
Collaborator

Hey all, little update - am currently chasing up @mitchellvanw about this as I have a part to play as well (finalising and testing). I believe he's quite busy atm as he's been unresponsive the past week or so, but we'll get around to it.

Until then, I do recommend using the forks and support others have written for now. Hopefully we'll have something up soon :)

@rreynier
Copy link

Any update on an official release?

@boris-glumpler
Copy link

I'm gonna need some extra functionality pretty soon. Am happy to do pull requests for those, but a little update on the state of the project would be nice before I invest some time only to find out that it isn't going anywhere. Cheers!

@FoxxMD
Copy link
Contributor

FoxxMD commented Apr 17, 2015

All: I've added cache:clear-* commands to artisan in my laravel 5 branch just FYI.

@kirkbushell If you'd like help getting an l5 version ready shoot me an email.

@pwm
Copy link

pwm commented May 7, 2015

Thanks FoxxMD, will check it out. Any update on the official?

@FoxxMD
Copy link
Contributor

FoxxMD commented May 20, 2015

All,

Thanks to the @evopix I have added some more very useful functionality to my laravel 5 fork.
(Original comment and full setup above)

What's new:

If you are using my fork with ANNOTATIONS ONLY nothing is required of you to take advantage of these changes, just run composer update to get the new functionality!

However if you would like to move to the new config schema (again, not required) the only change you need to make to doctrine.config is this:

'entity_managers' => [
    'default' => [
        ...
        'simple_annotations' => false, //remove this
        'metadata' => [
            'simple' => false //add this
            'driver' => 'annotation' //OPTIONAL, defaults to annotation if not provided
        ],
    ],

If you want to use XML or YAML drivers this is setup inside the metadata property of your entity_manager array:

'entity_managers' => [
    'default' => [
        ...
        'metadata' => [
            'simple' => false //instead of simple_annotations,
            'driver' => 'yaml', //or 'xml' or 'annotation'
            'paths' => [base_path('app/Models/mappings')],
            'extension' => '.dcm.yml'
        ],
    ],

As always, @kirkbushell and @mitchellvanw if you'd like to merge in my fork please let me know.

@FoxxMD FoxxMD mentioned this issue May 20, 2015
@rreynier
Copy link

Thanks @FoxxMD, I hope this ends up being merged soon!

@melloc01
Copy link

@FoxxMD Matt, you should update your readme 👍

@FoxxMD
Copy link
Contributor

FoxxMD commented May 26, 2015

@rcbytes Updated the readme! It now includes all information I've provided in this thread.

@jurosh
Copy link

jurosh commented Jun 16, 2015

Hi guys are you planning to merge changes? There is also possibility to split from @mitchellvanw branch if he is not maintaining it anymore...

@npmarrin
Copy link

I hate stomping on @mitchellvanw project but if we don't see any traction I would treat @FoxxMD project as the current maintained fork.

@josenicomaia
Copy link

+1

@FoxxMD
Copy link
Contributor

FoxxMD commented Jun 24, 2015

I've added support for DoctrineExtensions. Check the readme for details on installation and configuration.

@josenicomaia
Copy link

@FoxxMD
Copy link
Contributor

FoxxMD commented Sep 23, 2015

For anyone viewing this issue please use laravel-doctrine/orm instead!

We have a much more feature-complete, stable, and up to date integration for Doctrine 2 with Laravel 5+

@mitchellvanw
Copy link
Owner

Closing because project is no longer maintained. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests