Merge pull request moonsharp-devs#273 from ebeem/master

LimpingNinja · web-flow · commit 533e8b0f227b · 2021-11-14T22:11:13.000+01:00
fix Unicode2Ascii does not return char of ascii code 255 (fixes moonsharp-devs#256)
diff --git a/src/MoonSharp.Interpreter/CoreLib/StringModule.cs b/src/MoonSharp.Interpreter/CoreLib/StringModule.cs
@@ -102,7 +102,7 @@ public static DynValue unicode(ScriptExecutionContext executionContext, Callback
 
 		private static int Unicode2Ascii(int i)
 		{
-			if (i >= 0 && i < 255)
+			if (i >= 0 && i <= 255)
 				return i;
 
 			return (int)'?';
diff --git a/src/MoonSharp.Interpreter/_Projects/MoonSharp.Interpreter.netcore/src/CoreLib/StringModule.cs b/src/MoonSharp.Interpreter/_Projects/MoonSharp.Interpreter.netcore/src/CoreLib/StringModule.cs
@@ -102,7 +102,7 @@ public static DynValue unicode(ScriptExecutionContext executionContext, Callback
 
 		private static int Unicode2Ascii(int i)
 		{
-			if (i >= 0 && i < 255)
+			if (i >= 0 && i <= 255)
 				return i;
 
 			return (int)'?';

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public static DynValue unicode(ScriptExecutionContext executionContext, Callback`
`102`	`102`
`103`	`103`	`private static int Unicode2Ascii(int i)`
`104`	`104`	`{`
`105`		`- if (i >= 0 && i < 255)`
	`105`	`+ if (i >= 0 && i <= 255)`
`106`	`106`	`return i;`
`107`	`107`
`108`	`108`	`return (int)'?';`