Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound reactions #264

Closed
stemy2 opened this issue Dec 6, 2024 · 10 comments
Closed

Sound reactions #264

stemy2 opened this issue Dec 6, 2024 · 10 comments
Labels
feature-request Feature request good first issue Good for newcomers

Comments

@stemy2
Copy link

stemy2 commented Dec 6, 2024

Feature request

Hello,

It's a feature i saw on other voIP apps, that allow you to react with a sound like laughs, applause or sad trombone, to cite a few examples. Mirotalk would be perfect with a such ability.

Pros

It would add more fun in conversations.

Additional context

No response

@stemy2 stemy2 added the feature-request Feature request label Dec 6, 2024
@miroslavpejic85 miroslavpejic85 added the good first issue Good for newcomers label Dec 7, 2024
@miroslavpejic85
Copy link
Owner

mirotalk-p2p-emoji-sounds

I've added emoji sound reactions (applause, laughs, trombone) with a new method called handleEmojiSound. Feel free to add more as needed. The method's comment includes useful links related to this feature.

@miroslavpejic85
Copy link
Owner

miroslavpejic85 commented Jan 2, 2025

Current most used supported sound emoji:

👍 😀 😃 😂 😘 ❤️ 🎺 🎉 😮 👏

@stemy2
Copy link
Author

stemy2 commented Jan 2, 2025

Current most used supported sound emoji:

👍 😀 😃 😂 😘 ❤️ 🎺 🎉 😮 👏

I tried these emoticons, but they aren't producing any sound.

@miroslavpejic85
Copy link
Owner

I tried these emoticons, but they aren't producing any sound.

When you tried it, keep in mind that the chat emoji is different from the room emoji. You should use the second one from the left in the buttons.

@stemy2
Copy link
Author

stemy2 commented Jan 2, 2025

I tried these emoticons, but they aren't producing any sound.

When you tried it, keep in mind that the chat emoji is different from the room emoji. You should use the second one from the left in the buttons.

I actually used room emojis, just like the example you provided here: #264 (comment), but i can only see the notification on the left-bottom corner without hearing the sound they are supposed to produce.

@miroslavpejic85
Copy link
Owner

Could you provide the device, browser type and versions, and confirm if it has been tested in your live demo? Thank you.

@stemy2
Copy link
Author

stemy2 commented Jan 2, 2025

It works on the live demo, but not on the instance of my own homeserver, even if i updated it to the 2024.12.29 version.

@miroslavpejic85
Copy link
Owner

miroslavpejic85 commented Jan 2, 2025

It works on the live demo, but not on the instance of my own homeserver, even if i updated it to the 2024.12.29 version.

Please note that the issue you encountered is not related to the official MiroTalk P2P release. In the future, to avoid confusion, I kindly recommend referring to the official live demo before stating that something is not working. I am unsure where the deployment is taking place, or whether Docker is being used, but it is likely that the version has not been updated correctly to the latest release (1.4.30) on your homeserver. Thank you for your understanding.

@miroslavpejic85
Copy link
Owner

Update: Current emojis with sound reactions: 👍 👌 😀 😃 😂 😘 ❤️ 🎺 🎉 😮 👏 ✨ ⭐ 🌟 💫 🚀

@stemy2
Copy link
Author

stemy2 commented Jan 15, 2025

A nice enhancement could be using a specific category for the sounds emojis, so people could have the info elsewhere than in this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants