-
Notifications
You must be signed in to change notification settings - Fork 118
Implement current MIREX key scoring method (Updated) #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # mir_eval/key.py
|
This looks good to me, any objections before merging @stefan-baumann @bmcfee ? |
|
Seems ok to me. Thanks @instr3 ! |
|
Looks like there's one lint-related error and then a codecov error and possibly an error related to checking valid URLs, with some URLs gone invalid. @instr3 can you fix the lint issue (run black on everything)? @bmcfee any ideas about the codecov thing? I can look into and fix the URLs (probably involves removing them or pointing to archive.org) |
|
I think the codecov issue is still out of our control. As I recall, it stems from having migrated from a personal repo to an org, which somehow (?!) broke PR uploads for non-org-members. There were a smattering of auth-related issues with codecov over the past year, and I haven't kept tabs on it lately. Maybe there's a known fix by now? |
|
Hmm, the problem URLs seem fine for me too so perhaps that's just transient. So let's just fix the lint and we can merge. |
|
Merged, thans! |
Reviewed #339 and resolved the conflicts
The solution of the PR #339 is simple and efficient, and I do not think extra modifications are required once the conflicts are resolved.
Junyan