Skip to content

Dead code in makeRequestStreamAsync()? #1400

New issue
New issue
Open
#1401
Open
Dead code in makeRequestStreamAsync()?#1400
#1401
@alxndrsn

Description

@alxndrsn
alxndrsn
opened on Apr 3, 2025

parseResponseError() throws rather than returns it's result at

minio-js/src/internal/xml-parser.ts

Lines 117 to 119 in d8c6721

throw e
}

This means that at

minio-js/src/internal/client.ts

Lines 739 to 741 in d8c6721

const err = await xmlParsers.parseResponseError(response)
this.logHTTP(reqOptions, response, err)
throw err
, makeRequestStreamAsync() does not call this.logHTTP() at line 740.

I noticed this, as ?location requests do not seem to emit close events.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions