Skip to content

Commit ab1f366

Browse files
committed
Merge branch '2021.1' into 2021.2
2 parents 5e3bfcc + c4cf835 commit ab1f366

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

readme.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,25 @@ Minecraft Development for IntelliJ
1212
<td colspan="2"><a href="https://ci.demonwav.com/viewType.html?buildTypeId=MinecraftDev_Build"><img src="https://tc.demonwav.com/app/rest/builds/buildType:(id:MinecraftDev_Build)/statusIcon.svg" alt="Teamcity Build Status" /></a></td>
1313
</tr>
1414
<tr>
15-
<td align="right" rowspan="4" ><b>Nightly Builds</b></td>
15+
<td align="right" rowspan="5" ><b>Nightly Builds</b></td>
1616
<td align="left">2020.1</td>
17-
<td align="left"><a href="https://ci.demonwav.com/viewType.html?buildTypeId=MinecraftDev_Nightly_20201"><img src="https://tc.demonwav.com/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20201)/statusIcon.svg" alt="2020.1 Nightly Status" /></a></td>
17+
<td align="left"><a href="https://ci.denwav.dev/viewType.html?buildTypeId=MinecraftDev_Nightly_20201"><img src="https://ci.denwav.dev/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20201)/statusIcon.svg" alt="2020.1 Nightly Status" /></a></td>
1818
</tr>
1919
<tr>
2020
<td align="left">2020.2</td>
21-
<td align="left"><a href="https://ci.demonwav.com/viewType.html?buildTypeId=MinecraftDev_Nightly_20202"><img src="https://tc.demonwav.com/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20202)/statusIcon.svg" alt="2020.2 Nightly Status" /></a></td>
21+
<td align="left"><a href="https://ci.denwav.dev/viewType.html?buildTypeId=MinecraftDev_Nightly_20202"><img src="https://ci.denwav.dev/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20202)/statusIcon.svg" alt="2020.2 Nightly Status" /></a></td>
2222
</tr>
2323
<tr>
2424
<td align="left">2020.3</td>
25-
<td align="left"><a href="https://ci.demonwav.com/viewType.html?buildTypeId=MinecraftDev_Nightly_20203"><img src="https://tc.demonwav.com/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20203)/statusIcon.svg" alt="2020.3 Nightly Status" /></a></td>
25+
<td align="left"><a href="https://ci.denwav.dev/viewType.html?buildTypeId=MinecraftDev_Nightly_20203"><img src="https://ci.denwav.dev/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20203)/statusIcon.svg" alt="2020.3 Nightly Status" /></a></td>
2626
</tr>
2727
<tr>
2828
<td align="left">2021.1</td>
29-
<td align="left"><a href="https://ci.demonwav.com/viewType.html?buildTypeId=MinecraftDev_Nightly_20211"><img src="https://tc.demonwav.com/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20211)/statusIcon.svg" alt="2021.1 EAP Nightly Status" /></a></td>
29+
<td align="left"><a href="https://ci.denwav.dev/viewType.html?buildTypeId=MinecraftDev_Nightly_20211"><img src="https://ci.denwav.dev/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20211)/statusIcon.svg" alt="2021.1 Nightly Status" /></a></td>
30+
</tr>
31+
<tr>
32+
<td align="left">2021.2 EAP</td>
33+
<td align="left"><a href="https://ci.denwav.dev/viewType.html?buildTypeId=MinecraftDev_Nightly_20212"><img src="https://ci.denwav.dev/app/rest/builds/buildType:(id:MinecraftDev_Nightly_20212)/statusIcon.svg" alt="2021.2 EAP Nightly Status" /></a></td>
3034
</tr>
3135
<tr>
3236
<td align="right"><b>OS Tests</b></td>

src/main/kotlin/insight/ColorLineMarkerProvider.kt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ class ColorLineMarkerProvider : LineMarkerProvider {
6565
ColorIcon(12, color),
6666
FunctionUtil.nullConstant<Any, String>(),
6767
GutterIconNavigationHandler handler@{ _, psiElement ->
68-
if (!psiElement.isWritable || !element.isValid) {
68+
if (psiElement == null || !psiElement.isWritable || !psiElement.isValid || !workElement.isPsiValid) {
6969
return@handler
7070
}
7171

72-
val editor = PsiEditorUtil.findEditor(element) ?: return@handler
72+
val editor = PsiEditorUtil.findEditor(psiElement) ?: return@handler
7373

7474
val picker = ColorPicker(map, editor.component)
7575
val newColor = picker.showDialog()
@@ -117,18 +117,20 @@ class ColorLineMarkerProvider : LineMarkerProvider {
117117
) : ColorLineMarkerProvider.ColorInfo(
118118
element,
119119
color,
120-
GutterIconNavigationHandler handler@{ _, _ ->
121-
if (!element.isWritable || !element.isValid) {
120+
GutterIconNavigationHandler handler@{ _, psiElement ->
121+
if (psiElement == null || !psiElement.isValid ||
122+
!workElement.isPsiValid || workElement.sourcePsi?.isWritable != true
123+
) {
122124
return@handler
123125
}
124126

125-
val editor = PsiEditorUtil.findEditor(element) ?: return@handler
126-
if (JVMElementFactories.getFactory(element.language, element.project) == null) {
127+
val editor = PsiEditorUtil.findEditor(psiElement) ?: return@handler
128+
if (JVMElementFactories.getFactory(psiElement.language, psiElement.project) == null) {
127129
// The setColor methods used here require a JVMElementFactory. Unfortunately the Kotlin plugin does not
128130
// implement it yet. It is better to not display the color chooser at all than deceiving users after
129131
// after they chose a color
130132
HintManager.getInstance()
131-
.showErrorHint(editor, "Can't change colors in " + element.language.displayName)
133+
.showErrorHint(editor, "Can't change colors in " + psiElement.language.displayName)
132134
return@handler
133135
}
134136

0 commit comments

Comments
 (0)